Bug #745
closed
Interface groups cannot be named LAN, WAN or OPTx
100%
Description
You can't name an interface group as WAN, LAN, or OPTx because the rules are associated by the interface identifier (wan, lan, opt1, etc.) which do not (and shouldn't) change when the interface is renamed. Maybe append interface groups association with 'group', so LAN becomes 'langroup'? Or add input validation to not allow naming groups as LAN, WAN, or OPTx.
Files
Updated by Chris Buechler over 14 years ago
- Status changed from New to Feedback
2 moved to #746
1. I don't see, if you edit a rule that's assigned to a group, it stays with that group. If you edit a rule on an interface, it stays on that interface. I don't see any scenario where the interface is wrong.
Updated by Mr Horizontal over 14 years ago
- File select.jpg select.jpg added
- File in_rule.jpg in_rule.jpg added
Just updated to latest snap (previously had Jun 15 where I noticed this issue), and it's still there.
This probably due to my dodgy naming of the Interface Group. My LAN interfaces are called GBIT, 100M and WIFI, and the group itself is called LAN...
See here when I go to the rules table page (select.jpg) and when in the rule (in_rule.jpg)
Updated by Chris Buechler over 14 years ago
- Subject changed from Interface Group GUI niggles to Interface groups cannot be named LAN, WAN or OPTx
- Status changed from Feedback to New
original updated with actual issue.
Updated by Mr Horizontal over 14 years ago
Confirm the renaming resolves the selection issue, and sorry for being a numpty naming it as such!
That said, can you add a small validator on the Interface Group creation page in assign interfaces to just ensure that groups aren't named with such illegal names?
Updated by Ermal Luçi over 14 years ago
- Status changed from New to Feedback
- % Done changed from 0 to 100
Applied in changeset 4a71c0873c237ecd4c6e50337b8550e3bb4184c2.