Project

General

Profile

Feature #7529

CPU Type

Added by Philip Hadfield over 2 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Low
Assignee:
Category:
Web Interface
Target version:
Start date:
05/08/2017
Due date:
% Done:

100%

Estimated time:

Description

In Cpu type can you have a AES Yes/No

Associated revisions

Revision a84e59a2 (diff)
Added by Jim Pingle over 2 years ago

Show if a CPU has AES-NI/CPU crypto support even if the module isn't loaded. Implements #7529

Revision f8339acf (diff)
Added by Jim Pingle over 2 years ago

Fix active AES-NI test. Ticket #7529

History

#1 Updated by Kill Bill over 2 years ago

Kindly look at the "Hardware Crypto" field. If you don't see it then you don't have it.

#2 Updated by Jim Pingle over 2 years ago

That does only show up if you have the module loaded. If you don't load the module, nothing shows up, even if the CPU is capable. So there is some value in having it display something either way. Such as "AES-NI Capable: No" vs "AES-NI Capable: Yes (disabled)" vs "AES-NI Capable: Yes (enabled)" or similar. I tend not to want to say enabled/disabled though as that implies it would never be used, which isn't the case since OpenSSL/OpenVPN/etc latch on even with the module unloaded, but IPsec doesn't.

#3 Updated by Jim Pingle over 2 years ago

  • Assignee set to Jim Pingle

#4 Updated by Jim Pingle over 2 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

#5 Updated by Jo S over 2 years ago

Looking at the commit, I think there is an error in functions.inc.php :
the line:
$cpucrypto_active = is_module_loaded('aesni');
should be placed before the line:
$cpucrypto_type .= ($cpucrypto_active) ? "(active)" : "(inactive)";

#6 Updated by Jim Pingle over 2 years ago

I shuffled that block of code around so much trying to get the wording/formatting right that one slipped by. I pushed a fix.

#7 Updated by Bipin Chandra over 2 years ago

works fine now, this can be closed

#8 Updated by Jim Pingle over 2 years ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF