pfSense

Kindly look at the "Hardware Crypto" field. If you don't see it then you don't have it.

That does only show up if you have the module loaded. If you don't load the module, nothing shows up, even if the CPU is capable. So there is some value in having it display something either way. Such as "AES-NI Capable: No" vs "AES-NI Capable: Yes (disabled)" vs "AES-NI Capable: Yes (enabled)" or similar. I tend not to want to say enabled/disabled though as that implies it would never be used, which isn't the case since OpenSSL/OpenVPN/etc latch on even with the module unloaded, but IPsec doesn't.

Looking at the commit, I think there is an error in functions.inc.php :
the line:
$cpucrypto_active = is_module_loaded('aesni');
should be placed before the line:
$cpucrypto_type .= ($cpucrypto_active) ? "(active)" : "(inactive)";

I shuffled that block of code around so much trying to get the wording/formatting right that one slipped by. I pushed a fix.

works fine now, this can be closed