Project

General

Profile

Feature #8356

igmp, Add option to disable the igmp service

Added by Pi Ba almost 2 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Jim Pingle
Category:
IGMP Proxy
Target version:
2.4.3
Start date:
03/04/2018
Due date:
% Done:

100%

Estimated time:

Description

Add option to disable the igmp service

https://github.com/pfsense/pfsense/pull/3911

09-03-2018_13_59_23.png (32.3 KB) 09-03-2018_13_59_23.png Enable IGMP unchecked coming from 2.4.2 James Dekker, 03/09/2018 01:06 PM
09-03-2018_13_59_10.png (37.9 KB) 09-03-2018_13_59_10.png IGMP proxy still up and running James Dekker, 03/09/2018 01:06 PM

Associated revisions

Revision ca5270b6 (diff)
Added by Jim Pingle almost 2 years ago

Correct variable reference for IGMP proxy enable in upgrade code. Fixes #8356

Revision c7500634 (diff)
Added by Jim Pingle almost 2 years ago

Fix one more IGMP ref. Fixes #8356

History

#1 Updated by Jim Pingle almost 2 years ago

  • Status changed from New to Feedback

PR has been merged

#2 Updated by James Dekker almost 2 years ago

With igmp proxy configured on 2.4.2(or p1), upgrade to 2.4.3 (running 2.4.3.a.20180308.1837 here). The config keeps igmp proxy enabled, the service starts and runs, but in the gui it shows disabled.

This is how the config looks at the point described above:

    <igmpproxy>
        <igmpentry>
            <ifname>wan</ifname>
            <threshold></threshold>
            <type>upstream</type>
            <address>172.21.x.x/29</address>
            <descr><![CDATA[test-wan]]></descr>
        </igmpentry>
        <igmpentry>
            <ifname>lan</ifname>
            <threshold></threshold>
            <type>downstream</type>
            <address>10.0.0.1/8</address>
            <descr><![CDATA[test-lan]]></descr>
        </igmpentry>
        <enabled></enabled>
    </igmpproxy>

Checking the 'Enable IGMP' box and saving, applying, then unchecking the box, saving and applying does not stop the service.

#3 Updated by Jim Pingle almost 2 years ago

  • Status changed from Feedback to New

#4 Updated by Jim Pingle almost 2 years ago

  • Assignee set to Jim Pingle

#5 Updated by Jim Pingle almost 2 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

#6 Updated by James Dekker almost 2 years ago

Works as expected. With the checkbox unchecked, igmp proxy is disabled and not running. With the checkbox checked, igmp proxy is enabled and runs.

checkbox checked

    <igmpproxy>
        <igmpentry>
            <ifname>wan</ifname>
            <threshold></threshold>
            <type>upstream</type>
            <address>172.21.x.x/29</address>
            <descr><![CDATA[test-wan]]></descr>
        </igmpentry>
        <igmpentry>
            <ifname>lan</ifname>
            <threshold></threshold>
            <type>downstream</type>
            <address>10.0.0.1/8</address>
            <descr><![CDATA[test-lan]]></descr>
        </igmpentry>
        <enable></enable>
    </igmpproxy>

checkbox unchecked

    <igmpproxy>
        <igmpentry>
            <ifname>wan</ifname>
            <threshold></threshold>
            <type>upstream</type>
            <address>172.21.x.x/29</address>
            <descr><![CDATA[test-wan]]></descr>
        </igmpentry>
        <igmpentry>
            <ifname>lan</ifname>
            <threshold></threshold>
            <type>downstream</type>
            <address>10.0.0.1/8</address>
            <descr><![CDATA[test-lan]]></descr>
        </igmpentry>
    </igmpproxy>

#7 Updated by Jim Pingle almost 2 years ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF