Bug #8519
closed
pfSense update from the webGUI fails
100%
Description
When running an update from the web interface it can appear to fail and reports "System update failed".
In that situation it may continue to update in the background and will reboot some minutes later. Or it may require the update running for a second time when it then succeeds. You can't see from the gui page which of those situations you're in.
Files
| Selection_398.png (19 KB) Selection_398.png | |||
| Selection_458.png (68.7 KB) Selection_458.png |
Updated by Anonymous over 6 years ago
CHris Linstruth can reproduce the “fails once then succeeds” issue by simply installing 2.4.3 CE and attempting a GUI upgrade. More here: https://netgate.slack.com/files/U12B39VD4/FAP4XGASU/screen_shot_2018-05-15_at_12.04.27_am.png
Updated by Anonymous over 6 years ago
Based on the message that we can see on the GUI it seems that a ‘pfSense-upgrade -c’ call happened to check if there is a newer version available but GUI considered it was the real upgrade process that was running that output is from `pfSense-upgrade -c` for sure It was reported to happen in the past but I was never able to reproduce it.
We need to isolate all places that call pfSense-upgrade -c (including a cronjob) and think about a way to make sure the real upgrade call is running.
Updated by Anonymous over 6 years ago
- Status changed from New to Feedback
- % Done changed from 0 to 100
Applied in changeset dea792c210f62e1876e11523f4c9157c3531e1ba.
Updated by Jim Pingle over 6 years ago
- Status changed from Feedback to New
- Assignee changed from Renato Botelho to Anonymous
On an SG-1000 I occasionally get "The update system is busy. Please try again later" message despite starting the upgrade from the GUI. It isn't consistent, however. There may be a timing issue here on busy/slower platforms.
Updated by Steve Wheeler over 6 years ago
- File Selection_458.png Selection_458.png added
I have one test box which hits this on every single update. Always reports failure. Always updates fine in the background.
The machine itself is fast (G1820) but the storage is slow.
Updated by Anonymous over 6 years ago
- Assignee changed from Anonymous to Renato Botelho
Updated by Anonymous over 6 years ago
Debugging shows that the PID file used to determine whether the upgrade process is still running goes away unexpectedly.
$pidfile = $g['varrun_path'] . '/' . $g['product_name'] . '-upgrade.pid';
Reassigning to Renato, who has the upgrade hood open ATM for another issue.
Updated by Renato Botelho over 6 years ago
- Status changed from New to Resolved
System was running a modified version.
Updated by Renato Botelho over 6 years ago
- Status changed from Resolved to Feedback
We were able to reproduce it and a fix was pushed at 1d8cd2215b2a0131f69d2879f77c01204b7928c5
Updated by Jim Pingle over 6 years ago
- Status changed from Feedback to 13
Since that last commit, systems that were not experiencing problems before now fail to track the updates. They print this and nothing else, but the update continues:
Please wait while the update system initializes
Updated by Renato Botelho over 6 years ago
- Status changed from 13 to Feedback
Applied in changeset b3cd2eb41666e8c2e35c5ea1d2dea0862d12e6c8.
Updated by Anonymous over 6 years ago
Can't reproduce in VM from 2.4.3 CE to 2.4.3_1, or 2.4.3_1 to 2.4.4 latest snapshot. Is there a specific device, design or configuration this should be tested with?
Updated by Steve Wheeler over 6 years ago
Not seen any update issues for a few snaps now on a number of boxes.
Updated by Renato Botelho over 6 years ago
- Status changed from Feedback to Resolved
Updated by Jim Pingle over 6 years ago
I had several hitting this in my lab but only just now getting them onto snaps which included the latest fix. Let's give it another day / batch of updates to see how they all fare. If any are still broken I'll reopen.
Updated by Jim Pingle over 6 years ago
All of my hosts that had issues before appear to be OK when upgrading from snaps from early yesterday to the latest available.