Project

General

Profile

Actions

Bug #8519

closed

pfSense update from the webGUI fails

Added by Steve Wheeler about 4 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Category:
Upgrade
Target version:
Start date:
05/15/2018
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.4.3_1
Affected Architecture:
All

Description

When running an update from the web interface it can appear to fail and reports "System update failed".

In that situation it may continue to update in the background and will reboot some minutes later. Or it may require the update running for a second time when it then succeeds. You can't see from the gui page which of those situations you're in.


Files

Selection_398.png (19 KB) Selection_398.png Steve Wheeler, 05/15/2018 06:31 AM
Selection_458.png (68.7 KB) Selection_458.png Steve Wheeler, 08/06/2018 05:53 PM
Actions #1

Updated by Anonymous about 4 years ago

CHris Linstruth can reproduce the “fails once then succeeds” issue by simply installing 2.4.3 CE and attempting a GUI upgrade. More here: https://netgate.slack.com/files/U12B39VD4/FAP4XGASU/screen_shot_2018-05-15_at_12.04.27_am.png

Actions #2

Updated by Anonymous about 4 years ago

Based on the message that we can see on the GUI it seems that a ‘pfSense-upgrade -c’ call happened to check if there is a newer version available but GUI considered it was the real upgrade process that was running that output is from `pfSense-upgrade -c` for sure It was reported to happen in the past but I was never able to reproduce it.

We need to isolate all places that call pfSense-upgrade -c (including a cronjob) and think about a way to make sure the real upgrade call is running.

Actions #3

Updated by Anonymous about 4 years ago

  • Assignee set to Renato Botelho
Actions #4

Updated by Anonymous about 4 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100
Actions #5

Updated by Jim Pingle almost 4 years ago

  • Status changed from Feedback to New
  • Assignee changed from Renato Botelho to Anonymous

On an SG-1000 I occasionally get "The update system is busy. Please try again later" message despite starting the upgrade from the GUI. It isn't consistent, however. There may be a timing issue here on busy/slower platforms.

Actions #6

Updated by Anonymous almost 4 years ago

  • Status changed from New to 13
Actions #7

Updated by Anonymous almost 4 years ago

  • Status changed from 13 to New
Actions #8

Updated by Steve Wheeler almost 4 years ago

I have one test box which hits this on every single update. Always reports failure. Always updates fine in the background.

The machine itself is fast (G1820) but the storage is slow.

Actions #9

Updated by Anonymous almost 4 years ago

  • Assignee changed from Anonymous to Renato Botelho
Actions #10

Updated by Anonymous almost 4 years ago

Debugging shows that the PID file used to determine whether the upgrade process is still running goes away unexpectedly.

$pidfile = $g['varrun_path'] . '/' . $g['product_name'] . '-upgrade.pid';

Reassigning to Renato, who has the upgrade hood open ATM for another issue.

Actions #11

Updated by Renato Botelho almost 4 years ago

  • Status changed from New to Resolved

System was running a modified version.

Actions #12

Updated by Renato Botelho almost 4 years ago

  • Status changed from Resolved to Feedback

We were able to reproduce it and a fix was pushed at 1d8cd2215b2a0131f69d2879f77c01204b7928c5

Actions #13

Updated by Jim Pingle almost 4 years ago

  • Status changed from Feedback to 13

Since that last commit, systems that were not experiencing problems before now fail to track the updates. They print this and nothing else, but the update continues:

Please wait while the update system initializes

Actions #14

Updated by Renato Botelho almost 4 years ago

  • Status changed from 13 to Feedback
Actions #15

Updated by Anonymous over 3 years ago

Can't reproduce in VM from 2.4.3 CE to 2.4.3_1, or 2.4.3_1 to 2.4.4 latest snapshot. Is there a specific device, design or configuration this should be tested with?

Actions #16

Updated by Steve Wheeler over 3 years ago

Not seen any update issues for a few snaps now on a number of boxes.

Actions #17

Updated by Renato Botelho over 3 years ago

  • Status changed from Feedback to Resolved
Actions #18

Updated by Jim Pingle over 3 years ago

I had several hitting this in my lab but only just now getting them onto snaps which included the latest fix. Let's give it another day / batch of updates to see how they all fare. If any are still broken I'll reopen.

Actions #19

Updated by Jim Pingle over 3 years ago

All of my hosts that had issues before appear to be OK when upgrading from snaps from early yesterday to the latest available.

Actions

Also available in: Atom PDF