Bug #8903
closedpfBlockerNG: PHP error
0%
Description
Seeing this on a clean install of pfSense-2.4.4.r.20180914.1530 and restoring an existing config.
PHP Errors: [16-Sep-2018 16:44:57 Europe/London] PHP Warning: Illegal string offset 'rule' in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 114
Updated by Steve Wheeler over 5 years ago
Sorry clipped the line in the copy there. Actual warning is:
[16-Sep-2018 16:45:55 Europe/London] PHP Warning: Illegal string offset 'rule' in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 1146
Updated by Steve Wheeler over 5 years ago
This error looks to be triggering an unrequired config update:
--- /conf/backup/config-1537119183.xml 2018-09-16 18:33:05.281034000 +0100 +++ /conf/backup/config-1537119185.xml 2018-09-16 18:33:06.918551000 +0100 @@ -941,8 +941,8 @@ <sequence>system_information:col1:open:0,interfaces:col2:open:0,services_status:col2:open:0,gateways:col2:open:0,ipsec:col2:open:0,pfblockerng:col3:open:0,suricata_alerts:col3:open:0</sequence> </widgets> <revision> - <time>1537119183</time> - <description><![CDATA[(system): pfBlockerNG: saving earlyshellcmd]]></description> + <time>1537119185</time> + <description><![CDATA[(system): pfBlockerNG: saving DNSBL changes]]></description> <username>(system)</username> </revision> <openvpn>
Updated by BBcan177 . over 5 years ago
Steve, Are you sure this is not from pfBlockerNG-devel?
The pfBlockerNG version doesn't have 'rule' at that line?
https://github.com/pfsense/FreeBSD-ports/blob/devel/net/pfSense-pkg-pfBlockerNG/files/usr/local/pkg/pfblockerng/pfblockerng.inc#L1146
I can make this change in both version to be safe.
Updated by BBcan177 . over 5 years ago
Posted two PR to fix these issues and add other improvements.
https://github.com/pfsense/FreeBSD-ports/pull/567
https://github.com/pfsense/FreeBSD-ports/pull/569
Note: It doesn't address the earlyshellcmd issue as I am not sure if that is a pfBlockerNG issue?
Updated by Steve Wheeler over 5 years ago
Sorry, you're right, this is the -devel package. I'd forgotten I'd installed that.
I agree the earlyshellcmd issue looks to be a problem with shellcmd not pfBlocker.
Updated by Jim Pingle over 4 years ago
- Status changed from New to Resolved
PR was merged a long time ago.