Project

General

Profile

Bug #8974

system_advanced_admin.php: Inconsistent placement of ssh options and lack of initialization

Added by Jim Pingle 7 months ago. Updated 6 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
Start date:
09/28/2018
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.4.4
Affected Architecture:
All

Description

The sshdkeyonly setting is a bit confused about where it should be. Some references have $config['system']['ssh'] and others have $config['system']['sshd']. The port setting is under ssh so that should be used for consistency.

Also, when the configuration contains only <ssh></ssh> it does not properly store the settings due to the array not being initialized properly first.

Associated revisions

Revision ec439957 (diff)
Added by Jim Pingle 7 months ago

ssh settings alignment. Fixes #8974

Remove redundant settings stored in the wrong place
Store all ssh settings in the same place
Initialize this array before use

Revision 3b73574b (diff)
Added by Jim Pingle 7 months ago

ssh settings alignment. Fixes #8974

Remove redundant settings stored in the wrong place
Store all ssh settings in the same place
Initialize this array before use

(cherry picked from commit ec439957ce0f70778d89f57eba9553e2afba874a)

Revision efbe7d08 (diff)
Added by Jim Pingle 7 months ago

Issue #8974

(cherry picked from commit 32a7f1612b79ad04cc252d0a5e217c857b00024d)

History

#1 Updated by Jim Pingle 7 months ago

  • Subject changed from system_advanced_admin.php: Inconsistent use of $config['system']['ssh'] vs $config['system']['sshd'] and lack of initialization to system_advanced_admin.php: Inconsistent placement of ssh options and lack of initialization

A few other notes:

  • $config['system']['sshd'] appears to be redundant, the setting stored under $config['system']['sshd'] is also stored under $config['system']['ssh'] from a similar block of code not far from it.
  • The flag to enable sshd is not under $config['system']['ssh'] with the other options, and it should be.

Fix coming for all of this shortly.

#2 Updated by Jim Pingle 7 months ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

#3 Updated by Steve Wheeler 7 months ago

  • Status changed from Feedback to Resolved

Looks good. Functions as expected:

        <ssh>
            <enable>enabled</enable>
            <port>222</port>
            <sshdkeyonly>enabled</sshdkeyonly>
        </ssh>

Tested in:

2.4.5-DEVELOPMENT (amd64)
built on Sat Sep 29 22:31:00 EDT 2018
FreeBSD 11.2-RELEASE-p4

#4 Updated by Steve Beaver 7 months ago

  • Target version changed from 2.4.4-GS to 2.4.4_1

#5 Updated by Steve Beaver 7 months ago

  • Target version changed from 2.4.4_1 to 2.4.4-GS

#6 Updated by Jim Pingle 6 months ago

Also available in: Atom PDF