Project

General

Profile

Actions
Copy link

Bug #8974

closed
JP JP

system_advanced_admin.php: Inconsistent placement of ssh options and lack of initialization

Bug #8974: system_advanced_admin.php: Inconsistent placement of ssh options and lack of initialization

Added by Jim Pingle almost 8 years ago. Updated almost 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Jim Pingle
Category:
Web Interface
Target version:
2.4.4-GS
Start date:
09/28/2018
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.4.4
Affected Architecture:
All

Description

The sshdkeyonly setting is a bit confused about where it should be. Some references have $config['system']['ssh'] and others have $config['system']['sshd']. The port setting is under ssh so that should be used for consistency.

Also, when the configuration contains only <ssh></ssh> it does not properly store the settings due to the array not being initialized properly first.

JP Updated by Jim Pingle almost 8 years ago Actions
Copy link
 #1

  • Subject changed from system_advanced_admin.php: Inconsistent use of $config['system']['ssh'] vs $config['system']['sshd'] and lack of initialization to system_advanced_admin.php: Inconsistent placement of ssh options and lack of initialization

A few other notes:

  • $config['system']['sshd'] appears to be redundant, the setting stored under $config['system']['sshd'] is also stored under $config['system']['ssh'] from a similar block of code not far from it.
  • The flag to enable sshd is not under $config['system']['ssh'] with the other options, and it should be.

Fix coming for all of this shortly.

JP Updated by Jim Pingle almost 8 years ago Actions
Copy link
 #2

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

Applied in changeset commit:ec439957ce0f70778d89f57eba9553e2afba874a.

SW Updated by Steve Wheeler almost 8 years ago Actions
Copy link
 #3

  • Status changed from Feedback to Resolved

Looks good. Functions as expected:

        <ssh>
            <enable>enabled</enable>
            <port>222</port>
            <sshdkeyonly>enabled</sshdkeyonly>
        </ssh>

Tested in:

2.4.5-DEVELOPMENT (amd64)
built on Sat Sep 29 22:31:00 EDT 2018
FreeBSD 11.2-RELEASE-p4

Updated by Anonymous almost 8 years ago Actions
Copy link
 #4

  • Target version changed from 2.4.4-GS to 2.4.4-p1

Updated by Anonymous almost 8 years ago Actions
Copy link
 #5

  • Target version changed from 2.4.4-p1 to 2.4.4-GS

JP Updated by Jim Pingle almost 8 years ago Actions
Copy link
 #6

Also relevant/related: commit:8038c4e807c88fda4e1bb5b37ac31c9dbb8395fe

Actions
Copy link

Also available in: Atom