Bug #8974
closed
system_advanced_admin.php: Inconsistent placement of ssh options and lack of initialization
Added by Jim Pingle over 5 years ago.
Updated over 5 years ago.
Affected Architecture:
All
Description
The sshdkeyonly setting is a bit confused about where it should be. Some references have $config['system']['ssh'] and others have $config['system']['sshd']. The port setting is under ssh so that should be used for consistency.
Also, when the configuration contains only <ssh></ssh> it does not properly store the settings due to the array not being initialized properly first.
- Subject changed from system_advanced_admin.php: Inconsistent use of $config['system']['ssh'] vs $config['system']['sshd'] and lack of initialization to system_advanced_admin.php: Inconsistent placement of ssh options and lack of initialization
A few other notes:
$config['system']['sshd'] appears to be redundant, the setting stored under $config['system']['sshd'] is also stored under $config['system']['ssh'] from a similar block of code not far from it.- The flag to enable sshd is not under
$config['system']['ssh'] with the other options, and it should be.
Fix coming for all of this shortly.
- Status changed from New to Feedback
- % Done changed from 0 to 100
- Status changed from Feedback to Resolved
Looks good. Functions as expected:
<ssh>
<enable>enabled</enable>
<port>222</port>
<sshdkeyonly>enabled</sshdkeyonly>
</ssh>
Tested in:
2.4.5-DEVELOPMENT (amd64)
built on Sat Sep 29 22:31:00 EDT 2018
FreeBSD 11.2-RELEASE-p4
- Target version changed from 2.4.4-GS to 2.4.4-p1
- Target version changed from 2.4.4-p1 to 2.4.4-GS
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by Anonymous