Project

General

Profile

Actions
Copy link

Bug #9635

closed

lldpd (and probably ladvd) doesn't work on units with an integrated switch

Added by Brendon Baumgartner almost 5 years ago. Updated almost 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Renato Botelho
Category:
lldpd
Target version:
-
Start date:
07/17/2019
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Affected Version:
2.4.5
Affected Plus Version:
Affected Architecture:

Description

It appears the GUI configuration doesn't probably figure out what interface is selected. For example,

No matter what I do in the GUI, lldpd's startup file has this...
/usr/local/sbin/lldpd -l -I 'ix2,ix3' -C 'ix2,ix3' -m '172.22.18.2'
...and lldp doesn't work.

After I manually changed it to:
/usr/local/sbin/lldpd -l -I 'lagg0.4089' -C 'lagg0.4089' -m '172.22.18.2'
...it works.

This was thoroughly tested on an XG7100 but I'm pretty sure the same issue applies to SG3100s

Actions
Copy link
 #1

Updated by Jim Pingle over 4 years ago

  • Category set to lldpd
Actions
Copy link
 #2

Updated by Viktor Gurov over 4 years ago

  • Status changed from New to Resolved
  • Target version set to 2.4.5

no such issue on SG-3100 with pfSense 2.4.4-p3

lldpd updated to version 1.0.4 on 2.4.5/2.5

tested on pfSense 2.5.0.a.20191226.0326 and 2.4.5.a.20191226.1422 (XG-7100) - works as expected

Actions
Copy link
 #3

Updated by Viktor Gurov almost 4 years ago

  • Status changed from Resolved to New
  • Target version changed from 2.4.5 to 2.4.5-p1
  • Affected Version set to 2.4.5

After I manually changed it to:

After I manually changed it to:
/usr/local/sbin/lldpd -l -I 'lagg0.4089' -C 'lagg0.4089' -m '172.22.18.2'
...it works.

This was thoroughly tested on an XG7100 but I'm pretty sure the same issue applies to SG3100s

Still persist on at least XG-7100 and SG-1100 (pfSense 2.4.5, lldpd pkg 0.9.10)

on SG-1100 it creates incorrect lldpd.sh, which doesn't work:

/usr/local/sbin/lldpd -l -I 'mvneta0' -C 'mvneta0' -m '192.168.1.1'

but it works with:

/usr/local/sbin/lldpd -l -I 'mvneta0.4091' -C 'mvneta0.4091' -m '192.168.1.1'

it seems that we need to remove get_parent_physical_interface():
https://github.com/pfsense/FreeBSD-ports/blob/6cc36945256859e18f7a14d8f92848c4f98968f9/net-mgmt/pfSense-pkg-lldpd/files/usr/local/pkg/lldpd/lldpd.inc#L124

but needs testing with other interface types

Actions
Copy link
 #5

Updated by Jim Pingle almost 4 years ago

  • Status changed from New to Pull Request Review
Actions
Copy link
 #6

Updated by Renato Botelho almost 4 years ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Renato Botelho
  • Target version deleted (2.4.5-p1)
  • % Done changed from 0 to 100

PR has been merged. Thanks!

Actions
Copy link
 #7

Updated by Viktor Gurov almost 4 years ago

  • Status changed from Feedback to Resolved

tested on SG-1100 and XG-7100 - works as expected, lldpd uses the correct interfaces for integrated switches instead of the parent physical interfaces.

Actions
Copy link

Also available in: Atom PDF