Bug #9679: [Monitoring] Add View does not work - pfSense Packages - pfSense bugtracker

Actions

Copy link

Bug #9679

closed

[Monitoring] Add View does not work

Added by Grischa Zengel over 5 years ago. Updated over 5 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Jim Pingle

Category:

Status_Monitoring

Target version:

Start date:

08/12/2019

Due date:

% Done:

Estimated time:

Plus Target Version:

Affected Version:

2.4.4-p3

Affected Plus Version:

Affected Architecture:

Description

I added "WAN" as new View and got "wan" in lower letters. Why lower letters?
I removed it and now I can't add a new View.
If I add a new view "AAA" I get a green message box 'The "aaa" view has been added' but there is only Default.

There is a second bug:
If I open the add view dialog and press cancel I get: The "default" view has been added.

    <rrd>
        <enable></enable>
        <category>left=system-processor&amp;right=&amp;timePeriod=-1d&amp;resolution=300&amp;startDate=&amp;endDate=&amp;startTime=&amp;endTime=&amp;graphtype=line&amp;invert=true&amp;refresh-interval=0</category>
        <savedviews>A</savedviews>
    </rrd>

There is no view "A" visible.

Tested with Firefox and Chromium.

Actions

Copy link

Updated by Jim Pingle over 5 years ago

That XML result looks like what happens when there is an attempt by the code to use an uninitialized array. Shouldn't be a difficult bug to fix.

Actions

Copy link

Updated by Jim Pingle over 5 years ago

Status changed from New to Feedback
Assignee set to Jim Pingle

I was able to reproduce the problem here.

I pushed a new version of Status_Monitoring which corrects the usage of the savedviews array to avoid the problems you observed with adding/removing views.

You can update the package manually from the console or ssh shell with pkg upgrade -y pfSense-Status_Monitoring

The title case isn't related to this problem, but if you want to open a separate issue to investigate that, we can look into it.

Actions

Copy link

Updated by Grischa Zengel over 5 years ago

The first bug is fixed. Thank you!

On cancel I still get new "default" views:

    <rrd>
        <enable></enable>
        <category>left=system-processor&amp;right=&amp;timePeriod=-1d&amp;resolution=300&amp;startDate=&amp;endDate=&amp;startTime=&amp;endTime=&amp;graphtype=line&amp;invert=true&amp;refresh-interval=0</category>
        <savedviews>
            <view0>
                <title>wan</title>
                <category>left=wan-traffic&amp;right=&amp;timePeriod=-1d&amp;resolution=300&amp;startDate=&amp;endDate=&amp;startTime=&amp;endTime=&amp;graphtype=line&amp;invert=true&amp;refresh-interval=0</category>
            </view0>
            <view1>
                <title>default</title>
                <category>left=system-processor&amp;right=&amp;timePeriod=-1d&amp;resolution=300&amp;startDate=&amp;endDate=&amp;startTime=&amp;endTime=&amp;graphtype=line&amp;invert=true&amp;refresh-interval=0</category>
            </view1>
            <view2>
                <title>default</title>
                <category>left=ipsec-packets&amp;right=&amp;timePeriod=-1d&amp;resolution=300&amp;startDate=&amp;endDate=&amp;startTime=&amp;endTime=&amp;graphtype=line&amp;invert=true&amp;refresh-interval=0</category>
            </view2>
        </savedviews>
    </rrd>

Actions

Copy link

Updated by Jim Pingle over 5 years ago

Status changed from Feedback to In Progress

Actions

Copy link

Updated by Jim Pingle over 5 years ago

Status changed from In Progress to Feedback

I pushed a fix to avoid creating those extra "default" views, though they still cannot be deleted. You will have to manually remove those from your config.xml.

Actions

Copy link