Bug #9679
closed
[Monitoring] Add View does not work
Added by Grischa Zengel over 4 years ago.
Updated over 4 years ago.
Category:
Status_Monitoring
Affected Version:
2.4.4-p3
Description
I added "WAN" as new View and got "wan" in lower letters. Why lower letters?
I removed it and now I can't add a new View.
If I add a new view "AAA" I get a green message box 'The "aaa" view has been added' but there is only Default.
There is a second bug:
If I open the add view dialog and press cancel I get: The "default" view has been added.
<rrd>
<enable></enable>
<category>left=system-processor&right=&timePeriod=-1d&resolution=300&startDate=&endDate=&startTime=&endTime=&graphtype=line&invert=true&refresh-interval=0</category>
<savedviews>A</savedviews>
</rrd>
There is no view "A" visible.
Tested with Firefox and Chromium.
That XML result looks like what happens when there is an attempt by the code to use an uninitialized array. Shouldn't be a difficult bug to fix.
- Status changed from New to Feedback
- Assignee set to Jim Pingle
I was able to reproduce the problem here.
I pushed a new version of Status_Monitoring which corrects the usage of the savedviews array to avoid the problems you observed with adding/removing views.
You can update the package manually from the console or ssh shell with pkg upgrade -y pfSense-Status_Monitoring
The title case isn't related to this problem, but if you want to open a separate issue to investigate that, we can look into it.
The first bug is fixed. Thank you!
On cancel I still get new "default" views:
<rrd>
<enable></enable>
<category>left=system-processor&right=&timePeriod=-1d&resolution=300&startDate=&endDate=&startTime=&endTime=&graphtype=line&invert=true&refresh-interval=0</category>
<savedviews>
<view0>
<title>wan</title>
<category>left=wan-traffic&right=&timePeriod=-1d&resolution=300&startDate=&endDate=&startTime=&endTime=&graphtype=line&invert=true&refresh-interval=0</category>
</view0>
<view1>
<title>default</title>
<category>left=system-processor&right=&timePeriod=-1d&resolution=300&startDate=&endDate=&startTime=&endTime=&graphtype=line&invert=true&refresh-interval=0</category>
</view1>
<view2>
<title>default</title>
<category>left=ipsec-packets&right=&timePeriod=-1d&resolution=300&startDate=&endDate=&startTime=&endTime=&graphtype=line&invert=true&refresh-interval=0</category>
</view2>
</savedviews>
</rrd>
- Status changed from Feedback to In Progress
- Status changed from In Progress to Feedback
I pushed a fix to avoid creating those extra "default" views, though they still cannot be deleted. You will have to manually remove those from your config.xml.
There a no more new default tabs and removed the old one successfully with viconfig.
Thank you!
You can close this.
- Status changed from Feedback to Resolved
Great, thanks for testing!
Also available in: Atom
PDF
Updated by 
Updated by