Project

General

Profile

Feature #9742

Print Patch ID in log while patching

Added by Viktor Gurov 3 months ago. Updated 14 days ago.

Status:
Feedback
Priority:
Normal
Category:
System Patches
Target version:
-
Start date:
09/10/2019
Due date:
% Done:

100%

Estimated time:

Description

that would be very useful for support and security perspective.

for now it only run ACB backup while patching.

History

#1 Updated by Jim Pingle 3 months ago

  • Target version deleted (2.5.0)

#4 Updated by Jim Pingle about 2 months ago

  • Subject changed from print Patch ID in log while patching to Print Patch ID in log while patching
  • Status changed from New to Pull Request Review

#5 Updated by Renato Botelho about 1 month ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Renato Botelho
  • Target version set to 2.5.0
  • % Done changed from 0 to 100

PR has been merged. Thanks!

#7 Updated by Jim Pingle 23 days ago

  • Target version deleted (2.5.0)

#8 Updated by Viktor Gurov 15 days ago

tested on pfSense 2.5.0.a.20191121.2127 with System_Patches 1.2_4
test patch: https://github.com/pfsense/pfsense/commit/15701e03e36051907a23ddbe5ab04f42c94c0944.patch

Works ok, but on every patching I also got such message in logs:

Logging subprocess 84289 (exec /usr/local/sbin/sshguard) exited with status 1.

#9 Updated by Jim Pingle 14 days ago

The sshguard log message wouldn't be related.

I see logs for manual patching and reverting, but no log messages when auto-apply happens at boot time. It may not be the fault of the code, though, since it's an early shell command it may be run before logging starts, so logging via syslog at that point may not be possible. It has to run that early or it may not get run before other components that need to get patched before starting.

Instead of using syslog, it could write to its own log file directly, but that seems like overkill just for this.

Also available in: Atom PDF