Print Patch ID in log while patching
that would be very useful for support and security perspective.
for now it only run ACB backup while patching.
#8 Updated by Viktor Gurov 15 days ago
tested on pfSense 2.5.0.a.20191121.2127 with System_Patches 1.2_4
test patch: https://github.com/pfsense/pfsense/commit/15701e03e36051907a23ddbe5ab04f42c94c0944.patch
Works ok, but on every patching I also got such message in logs:
Logging subprocess 84289 (exec /usr/local/sbin/sshguard) exited with status 1.
#9 Updated by Jim Pingle 14 days ago
The sshguard log message wouldn't be related.
I see logs for manual patching and reverting, but no log messages when auto-apply happens at boot time. It may not be the fault of the code, though, since it's an early shell command it may be run before logging starts, so logging via syslog at that point may not be possible. It has to run that early or it may not get run before other components that need to get patched before starting.
Instead of using syslog, it could write to its own log file directly, but that seems like overkill just for this.