Project

General

Profile

Actions

Bug #9807

closed

Packets Monitoring graphs are being incorrectly scaled

Added by Steve Wheeler about 2 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
Normal
Category:
Status_Monitoring
Target version:
Start date:
10/03/2019
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Affected Version:
All
Affected Plus Version:
Affected Architecture:

Description

It looks like the data used for the packets logging is being incorrectly multiplied by 8 as though it is assuming a Bytes value that shouldn't be be applied to PPS.

Whilst running an iperf3 test the monitoring graphs show a pps value of 644.22 kpps but the switch port logs a 5s average of 80600 pps for the same connection.

Tested against:

2.5.0-DEVELOPMENT (amd64)
built on Sat Sep 28 22:21:52 EDT 2019
FreeBSD 12.0-RELEASE-p10

Also seen here in 2.4.4p3: https://forum.netgate.com/topic/147011/pfsense-monitoring-graphs


Files

rrd_fetch_json.php (12.5 KB) rrd_fetch_json.php fixed version Viktor Gurov, 12/12/2019 06:39 AM
Actions #1

Updated by Viktor Gurov almost 2 years ago

for some reason there is no rrd_fetch_json.php and status_monitoring.php files on github

fixed version:

...
                                case "inpass":
                                if ($settings['category'] === "traffic") {
                                        $multiplier = 8;
                                }
                                $ninetyfifth = true;
                                $format = "s";
                                break;
                        case "max":
                                $format = "s";
                                break;
                        case "inpass6":
                                if ($settings['category'] === "traffic") {
                                        $multiplier = 8;
                                }
                                $ninetyfifth = true;
                                $format = "s";
                                break;
                        case "outpass":
                                if ($settings['category'] === "traffic") {
                                        $multiplier = 8;
                                }
                                $invert = $invert_graph;
                                $ninetyfifth = true;
                                $format = "s";
                                break;
                        case "outpass6":
                                if ($settings['category'] === "traffic") {
                                        $multiplier = 8;
                                }
                                $invert = $invert_graph;
                                $ninetyfifth = true;
                                $format = "s";
...

Actions #2

Updated by Jim Pingle almost 2 years ago

  • Project changed from pfSense to pfSense Packages
  • Category changed from RRD Graphs to Status_Monitoring

They are a part of the Status_Monitoring package (which is included in the base install), so the files are in the freebsd-ports repo under sysutils/pfSense-Status_Monitoring

Actions #4

Updated by Jim Pingle almost 2 years ago

  • Status changed from New to Pull Request Review
Actions #5

Updated by Renato Botelho almost 2 years ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Renato Botelho
  • % Done changed from 0 to 100

PR has been merged. Thanks!

Actions #6

Updated by Jim Pingle almost 2 years ago

  • Target version changed from 2.5.0 to 2.4.5

This was picked back to 2.4.5 as well, so needs testing there.

Actions #7

Updated by Viktor Gurov almost 2 years ago

  • Status changed from Feedback to Resolved

tested on pfSense 2.4.5.a.20191220.1407

works,
Resolved

Actions

Also available in: Atom PDF