Actions
Feature #9816
closed
firewall_aliases.php: add ability to export list of aliases
Start date:
10/10/2019
Due date:
% Done:
100%
Estimated time:
Plus Target Version:
Release Notes:
Description
adds ability to export list of aliases
opens white page with only aliases - to copy&paste and save to txt
Updated by Viktor Gurov over 4 years ago
Updated by Jim Pingle over 4 years ago
- Status changed from New to Pull Request Review
- Target version deleted (
2.5.0)
Updated by Viktor Gurov over 4 years ago
Updated by Renato Botelho over 4 years ago
- Status changed from Pull Request Review to Feedback
- Assignee set to Renato Botelho
- Target version set to 2.4.5
- % Done changed from 0 to 100
PR has been merged. Thanks!
Updated by Viktor Gurov over 4 years ago
Renato Botelho wrote:
PR has been merged. Thanks!
it's ok on latest 2.5.0.a.20200107.2225
but error on 2.4.5.a.20200107.1903 when you click the "Export to file" button:
Fatal error: Uncaught Error: Call to undefined function send_user_download() in /usr/local/www/firewall_aliases_edit.php:132 Stack trace: #0 {main} thrown in /usr/local/www/firewall_aliases_edit.php on line 132 PHP ERROR: Type: 1, File: /usr/local/www/firewall_aliases_edit.php, Line: 132, Message: Uncaught Error: Call to undefined function send_user_download() in /usr/local/www/firewall_aliases_edit.php:132 Stack trace: #0 {main} thrown
Updated by Jim Pingle over 4 years ago
That function did not exist on 2.4.5. I picked back the changes which added and implemented the use of that function in the GUI. So in addition to testing the change from this issue we should also double check the changes made in 9896389be023a98ccfbbaaa49f94d069b874067f to ensure the other pages which use the new function still operate as expected.
Updated by Viktor Gurov over 4 years ago
- Status changed from Feedback to Resolved
tested on 2.4.5.a.20200108.1746
works as expected
Actions