pfSense

Fixed #5659

Fixed #5636

Merge pull request #2292 from phil-davis/patch-2

Merge pull request #2291 from phil-davis/snmax

Merge pull request #2289 from NOYB/HTML_Compliance_-_Wake_On_LAN_Widget

Merge pull request #2288 from NOYB/Status_-_System_Logs_-_Manage_Log_-_Input_Validation

Fixed #5653
Removed bogus code that forced system information to be first in the list
Added JS to always add system_information to col 1

Fix static DHCP address validation

1) Use gen_subnetv4 and gen_subnetv4_max rather than doing the guts of the calculation inline. (The ~gen_subnet_mask_long($ifcfgsn) thing was the cause of the problem)
2) Add validation checks to stop people using the network address or broadcast address as a statically allocated DHCP address....

Fix gen_subnetv4_max

and use it in services_dhcp rather than trying to do the similar
calculation in-line.
Should fix redmine #5654 and probably a bunch of other things that use
gen_subnet_max

Validate IP passthrough bandwidth values within sane range. Ticket #5655

Validate CP MAC passthrough bandwidth. Ticket #5655

HTML Compliance - Wake On LAN Widget

Align attribute not supported on td tag in HTML5 use css instead.
Center tag not supported in HTML5 use css instead.

Add max value to qty field.

Status - System Logs - Manage Log - Input Validation

Add input validation at form level in browser.
Keep PHP server side validation so as not to rely solely on the browser.

Merge pull request #2287 from NOYB/Interfaces_-_DHCP_Config_File_Override

Interfaces - DHCP Config File Override

Correct section label.

Interfaces - DHCP Advanced Options - Number Attributes

Protocol timing select timeout; override system minimum number attribute to allow zero.

Merge pull request #2285 from ExolonDX/branch_04

Merge pull request #2284 from ExolonDX/branch_03

Tidy up "services_igmpproxy.php"

- Close TH tag correctly

Tidy up "services_dhcp.php"

- Close TABLE correctly

Merge pull request #2283 from ExolonDX/branch_02

Tidy up "ntp_status.widget.php"

- Tidy up coding style
- Remove unnecessary DIV tab
- Update TABLE tag

Correct quotes around $ifdesc introduced in PR 2282

Tidy up "services_dyndns.php"

services_dyndns.php
- remove duplicate double quotes
- tidy up tabs/spaces

services_rfc2136.php
- remove duplicate double quotes
- tidy up tabs/spaces

dyn_dns_status.widget.php
- change echo to print
- change FONT tag to SPAN tags and use correct class...

Merge pull request #2281 from ExolonDX/master

Tidy up "status_wireless.php"

Remove closing FONT tags

Merge pull request #2280 from phil-davis/patch-4

services_rfc2136_edit remove unused $input

These bits if code that put new Form_Checkbox() into var $input do not seem to do anything useful. They just made me wonder why they were there.
If someone knows how they do anything useful, then please say so. Otherwise we can get rid of $input here.

Merge pull request #2279 from phil-davis/patch-2

Point more directly to Certificate Revocation page

This could point more directly to the Certificate Revocation page.

Nuke fifolog support. It was never used or fully implemented, no GUI option, and didn't end up working out.
It buffered writes too long, users could never see the most current log data.

system_usermanager remove unused code

1) Line 448 "Remove this certificate association? (Certificate will not be deleted)" there was the text "Delete" being displayed and not looking good, in addition to the trash bin icon. Just the trash bin icon seems to be all that is needed....

system_crlmanager dodgy else statement

The "else" that was at line 550 should enclose the whole block of code below it. The "if" handles the case "No Certificates Found for this CA." and all the code below the else should only happen when there are certificates found.

Change status.php state dump to use -vvss for more verbose info, add kenv and pkg info

Fixed #5650

Fixed #5648

Save button fix - part deux

Fix "Save" button jQuery

Merge pull request #2276 from phil-davis/r020

Merge pull request #2275 from phil-davis/patch-5

Merge pull request #2274 from phil-davis/r019

Merge pull request #2273 from phil-davis/patch-4

Merge pull request #2272 from NOYB/Interfaces_-_Assign_-_Wireless_-_PHP_Crash

Merge pull request #2271 from NOYB/System_-_Advanced_-_Admin_Access

Merge pull request #2270 from NOYB/Interfaces_-_DHCP_Advanced_Options_-_Require_Options

Merge pull request #2268 from NOYB/Interfaces_-_DHCP_Advanced_Options_-_Radio_Buttons

Merge pull request #2267 from phil-davis/r018

Merge pull request #2265 from phil-davis/r017

Merge pull request #2266 from NOYB/HTML_Compliance_-_Dashboard_-_Widget_Config_Panel

Merge pull request #2264 from NOYB/HTML_Compliance_-_Dashboard

Merge pull request #2263 from phil-davis/r016

Merge pull request #2262 from NOYB/HTML_Compliance_-_Traffic_Graphs_Widget

Merge pull request #2261 from NOYB/HTML_Compliance_-_Thermal_Sensors_Widget

Merge pull request #2260 from NOYB/HTML_Compliance_-_RSS_Widget

Merge pull request #2259 from NOYB/HTML_Compliance_-_Picture_Widget

Merge pull request #2258 from phil-davis/r015

Merge pull request #2257 from phil-davis/patch-3

Merge pull request #2256 from phil-davis/r014

services_pppoe_edit handle both GET and POST

This wacky logic would only have got to the $_POST checks if $_GET['id'] was already set.
I haven't looked to analyse it - but how would anything using $_POST have worked?

Code style v w

vpn_openvpn_server key name typos

Code style system_*

hasync synchronize DNS text

Interfaces - Assign - Wireless - PHP Crash

Fix unexpected EOF

System - Advanced - Admin Access

Fix hiding SSL Cert when HTTP protocol selected.

Interfaces - DHCP Advanced Options - Require Options

Fix Require options form input

Interfaces - DHCP Advanced Options - Radio Buttons

Fix the Protocol Timing - Presets radio buttons.

dyn_dns_status widget avoid var naming issue

This use of var $i was conflicting and interfering with a use of it in
index.php
Use a much more unique name for now to avoid future risk.
Maybe a proper final solution for var naming across dashboard and widget...

HTML Compliance - Dashboard - Widget Config Panel

Bad value #widget-system_information .panel-footer for attribute href on element a: Illegal character in fragment: not a URL code point.
Fix the widget config/wrench icon href.
Add matching widgetname id tag to widgets configuration panel div element....

Use different var name looping through columns

There is some problem with the var $i getting reset somehow somewhere
related to the include of each widget PHP code. I found that this was
doing $i = 1, $i = 2 and then $i = 2 again and I got fatal errors
because each widget code was being included twice....

HTML Compliance - Dashboard

Rename duplicate id's.
Fix available widgets collapsible section href with id.
Where obsolete replace name attribute with id.

The .panel-footer requires mod to the widgets with config options. So will submit separate commit so it can be handled independently....

Consolidate OpenVPN kill_client routine

After a gitsync just now I started getting "cannot redeclare
kill_client" error messages. Whatever it was that caused this to start
happening, the kill_client() function in these 2 places is identical.
Might as well put it in openvpn.inc

HTML Compliance - Traffic Graphs Widget

Syntax typo?
No space between attributes.
Quote " in attribute name. Probable cause: Matching quote missing somewhere earlier.
Attribute wan]" not allowed on element input at this point.

The for attribute of the label element must refer to a non-hidden form control. Add id tag.

HTML Compliance - Thermal Sensors Widget

The align attribute on the td element is obsolete. Use CSS instead.

HTML Compliance - RSS Widget

An img element must have an alt attribute, except under certain conditions. For details, consult guidance on providing text alternatives for images.
http://www.w3.org/wiki/HTML/Usage/TextAlternatives
The for attribute of the label element must refer to a non-hidden form control. Add id tag.

HTML Compliance - Picture Widget

In HTML 4.01, the width and height could be defined in pixels or in % of the containing element. In HTML5, the value must be in pixels. Use css for specifying in %.
The for attribute of the label element must refer to a non-hidden form control. Add id attribute.

Code style System Certificates

system_certmanager csr_dn_country keyname error

Someone was recently reporting a problem with certificate signing requests. Maybe this will help.

Code style services

Code style index.php

Couple of little bits here.

Further refinement to widget config

Fixed the broken widget config action (again)

no longer used

fixed issue where if all widgets were in col2, no col1 was created

Reverted commit 677d8bdfebace3321da677a57a0756a27332d505, PR 2218
because it broke all of the widget configuration actions.

move tree.css to main css files

Fixed table apeparance, headers, button placement and row drag/drop/move

clean up common colors

Corrected movable/sortble table row handling

improve firewall rules table (WIP)

Fixed #4915

Merge pull request #2252 from phil-davis/r013

Support <savehelp> package tag to allow adding help text to the save button.

Code style services dhcp dnsmasq dyndns

services_dyndns_edit requestif key name

This probably fixes forum thread https://forum.pfsense.org/index.php?topic=104076.0

Merge pull request #2250 from phil-davis/r012

Code style services captive portal

services_captiveportal text changes

Whitesapce change