pfSense

Remove some obsolete code from globals.inc

Fix handling of backup config count. Fixes #6771

Merge pull request #3071 from phil-davis/Check_IP_Services

Force changes in routing to be detected by the system

When dhcp6c without RA is enabled, dhcp6c isn't killed and respawned, this causes the system not being able to pick up the routing changes. In this case, running the configuration script which fires rc.newwanipv6 solves the problem....

DHCP6 Before RA. Additions and ammendments

Replaced posix_kill() in kill_dhcp6client_process() with mwexec("kill -9 $pid"), this is because the posix_kill call was not reliably killing the dhcp6c process, kill -9 works every time.

Changes to the rtsold script creation. The script lines starting dhcp6c should not have be written to the script when dhcpwithoutra is true....

Improve dhcpd and dhcpleases reload

1) Avoid running services_dhcpd_configure() more times than needed.
2) Always restart dhcpleases after it's killed during interface recycle.
3) It's not necessary to restart dhcpdv4 when doing changes in ipv6 config.

(cherry picked from commit 509e9357df4755a4fe5d1d9b20eda65bafb855e7)

Ensure only one instance of services_dhcpd_configure runs concurrently

This way kill and respawn will behave as they should for the dhcpd processes

(cherry picked from commit c69ea0051c5549a9db0d092e85b92f78ffb4c978)

Prevent accessing undefined offset in IPv6.inc

On perfectly good IPs (eg. 1:2::3:4) this code could cause the following notice:
Notice: Undefined offset: 2 in IPv6.inc on line 560

On bad IPs like 1::2::3 it would not result in any notice.

This commit fixes the above problem, while making sure that only valid sequences pass validation.

system_dhcpleases_configure() - Improve pidfile handling

1) Set the pidfile variable in the correct place.
pidfile variable is required in both 'if' and 'else' blocks.

2) Ensure pidfile is valid before sending term signal

(cherry picked from commit 4509abc380552554cbdf3f42c6783b47112f245a)

Apply the fix for ticket #6589 also into dhcpdv6 config

(cherry picked from commit 20350989db5d66ffb827beaed5ef5738cd62fc9d)