pfSense

coding layout fix
(cherry picked from commit 97eebb23531bc95af2cde686641080851107c42c)

remove gettext() not needed
(cherry picked from commit c7e31e37c1aa0a8e4154528a99a121c46ebf018d)

move implode() to same line as previous change
(cherry picked from commit 91822dc6d0b829a34254638c5d15db72fe70932d)

simplify avoiding loop. Also localise with gettext()
(cherry picked from commit 16b91b19e08e0778522c16e811754c22f03b5150)

Bugfixes

1. On creating a new rule, $pconfig['ipprotocol'] is undefined, rather than defaults to what is seen in GUI (IPv4). Form generation logic for the ICMPType list box can't rely on a good value. It was fixed late here and missed when copying changes to Github. Very likely responsible for above issue by @rbgarga . Please confirm if this fixes it for you. On the off-chance that it still doesn't, can you let me know if editing an existing rule works, which will help....

Improve icmptype input sanitising
(cherry picked from commit 0e782e9f576aee02d4e2e5147e24bc5def261355)

Enhance ICMP types in rules

See main PR for details
(cherry picked from commit cf1aaf9c5afcd34ed6d2bebc577fd527c42c80b4)

Enhance ICMP type handling in rules

See main PR for details
(cherry picked from commit 7a4b11b6a495ddc747db5e44f5a62891ef86398c)

Add privs to control display of notices

This is a suggested way to allow control of the display and clearing of
notices. The use case is:
1) A user with minimal page privs (e.g. can just change their password,
or access a few status pages or...) should not be automatically able to...

Put print_info_box severity class in quotes

These should be strings in quotes, otherwise PHP looks for them to be
constants and would be issuing notice level "errors" underneath.

(cherry picked from commit 499adf7352647e401fbaf496ebac8dfb9591ad97)