pfSense

Logging fixes. Ticket #5340

Merge pull request #1980 from doktornotor/patch-2

Merge pull request #1986 from phil-davis/patch-6

Merge pull request #1984 from phil-davis/patch-4

Use 1-6 rather than 0-5 for IPsec logging levels, to stay away from complications of 0 due to PHP stupidity. Upgrade config to add 1 to any configured log levels. Default to 1 as log level where none is configured by the user. Ticket #5340

Fix Command Prompt Download and Upload when not in English - Redmine #5343 for RELENG_2_2

Fix multi-lingual save of NAT mode Redmine # for RELENG_2_2

and forum https://forum.pfsense.org/index.php?topic=101276.0

Fix external interface variable in input error message

Properly validate IPv4 for UPnP - RELENG_2_2

Since https://redmine.pfsense.org/issues/1835 got exactly nowhere for the past 4 years, the input should be properly validated, instead of allowing people to configure nonfunctional/broken nonsense.

P.S. If you don't plan on fixing the above-linked feature for 2.3, let me know and I'll do the same for 2.3

interfaces_assign tab_array numbering

This was fixed in master for 2.3 by https://github.com/pfsense/pfsense/commit/50e6c063e6ec148917ff0bcb0bce8b0a08df5792 - in master all of these $tab_array entries, in each file that they appear in, had been modified to just use the $tab_array[] = form....