pfSense

Split ICMP and ICMPv6 types on Firewall Rules

- Remove redundant declaration of $icmptypes and move it to a common
place (filter.inc)
- Add missing ICMP types for v4
- Add ICMPv6 types
- Adjust javascripts to show correct options depending of IP Protocol...

Fix #4099:

- When interface is 'lo0', strpos returns 0, that is erroneously
considered false (boolean) on the test. Be more strict on strpos return
to avoid skiping lo0 ip aliases during sync.

Improve check if no OpenVPN defined

Alternate version of https://github.com/pfsense/pfsense/pull/1376
This version retains the is_array() checks and then only does the count() if the is_array() is true.
Take whichever version you like.

Setup ddb on all platforms. On full install it will save the dump, on NanoBSD it will print to console and auto-reboot.
This way, a router running NanoBSD won't sit at a db> prompt indefinitely if it crashes.

Make sure this message is only displayed on console

get_failover_interface() is already called inside get_interface_ip(v6), no need to call it twice. It should fix #4089

Use exit instead of return here, otherwise script's return code is always 0 and user with wrong password is authenticated

Provide success return indication from console_configure_dhcpd

Recent commit https://github.com/pfsense/pfsense/commit/9ea554ee5cb25ea3bf5bb6bf7997c6c7379ce349 added testing of the return status of console_configure_dhcpd() - this let a user effectively abort from doing anything if they have answered "y" to prompt_for_enable_dhcp_server() and are being asked for the start and end of the range, and then decide they do not want to proceed....

Disable RC4 ciphers in lighttpd

Call filter_configure_sync() is a better fix for #4066, as pointed by Ermal