pfSense

Ignore link-local IPv6 address from PPPoE DEVD events

Returns the behavior of ignoring LL addresses. The LL fallback is no
longer needed since the IPv6 peer address is now always included.

Followup to a0baea958c7fae9363c757317e9d52874a257b70

pppoe_handler: Remove ipv6 router workaround

With changes to if_pppoe, we not have an associated destination address for the
p2p address and the workaround is no longer necessary.

get_interface_addresses(): Change use of 'tunnel' for p2p destination addresses to 'dstaddr'

In the php module, the 'tunnel' address attribute returned from
pfSense_get_ifaddrs() has been renamed to 'dstaddr' to more appropriately
reflect that the address is a p2p destination. This change alters the behavior...

ppp-ipv6: Reduce indent levels

Refactor handling of PPPoE ADDR_ADD events. Fix #16265

Avoid loop between pppoe-handler and rc.newwanip. Fix #16235

Once the PPPoE client receives the interface address an ADDR_ADD DEVD
event triggers pppoe-handler which ends up calling rc.newwanip. The
rc.newwanip script calls link_interface_to_vips() which triggers an...

Fix double rc.newwanipv6 execution on if_pppoe

When using if_pppoe and DHCPv6 over the PPP link, both the devd handler script
and dhcp6c execute /etc/rc.newwanipv6 as a result of an address assignment,
which is not fatal but does cause some extra delay as the filter is reloaded and...

pppoe-handler: Mute spurious invalid address warnings

Move the address checking out of the main body of the script into switch cases
that actually use the address

(cherry picked from commit 51ce224e061a26728bb42d11d238a11bbd989850)

if_pppoe: Resolve endless loop on dhcp6c

When using if_pppoe, the use of ppp-ipv6 to up the pppoe interface on ADDR_ADD
causes a loop of calling interface_dhcp6_configure(), which
restarts dhcp6c, which acquires a lease and assigns an address, which emits an...

Fix config check for if_pppoe

'system/use_mpd5_for_pppoe' is not a valid config path.