pfSense

pkg.php consolidate else-if statement

Wrap pkg_full_path in htmlspecialchars()

Because it contains $xml which is itself wrapped in htmlspecialchars() for display.

Enhance error output when package file not found - RELENG_2_2

I had a system that had upgraded but the Notes package had not managed to (re)install. In that situation the Notes item is on the Status menu but there is no notes.xml or other notes code on the the system....

Use current interface description for breadcrumb - RELENG_2_2

If you enter invalid stuff in the interface description - e.g. "123" - and press save, then you get a warning about it, but the breadcrumb changes to "Interfaces: 123" - the wrongly entered description (that was not applied)....

Fix #5778 do not save changes if interface description matches an alias name - RELENG_2_2

Rationalize add and delete buttons for limiter GUI RELENG_2_2

This has annoyed me in the past. I noticed it in 2.3-BETA just now and went to look on a 2.2.6 system and realized it is an issue there also.
1) When you click to add a new limiter or new queue, then the "Add new queue" button is displayed down the bottom. That is dumb - you are already adding and actually you need to enter the data and save first before adding something else....

Fix redmine #5722 DHCP validation for RELENG_2_2

Might as well provide the fixes for RELENG_2_2 since it is easy and that is where I first tested. Even if there is never a 2.2.7, at least the fixes are there in GitHub to be seen.

Take this conditional out, it wasn't enough, and we have a script example for how to handle this properly now while respecting CSRF.

Only disable CSRF on diag_backup.php for the download action where it might be scripted. Other actions need its protection.

Encode hostname before printing; remove some related dead code.