Project

General

Profile

Bug #10270

OMAPI / disableauthoritative / alwaysbroadcast not saved inside dhcpd.conf

Added by Manuel Piovan 11 months ago. Updated 2 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Jim Pingle
Category:
DHCP (IPv4)
Target version:
2.5.0
Start date:
02/19/2020
Due date:
% Done:

0%

Estimated time:
Affected Version:
2.5.x
Affected Architecture:

Description

discussion here
https://forum.netgate.com/topic/150658/no-config-entry-for-omapi

with multiple lan network if i set OMAPI the generated dhcpd.conf does not contain any configuration about OMAPI

Associated revisions

Revision a6e1c192 (diff)
Added by Viktor Gurov 3 months ago

Save OMAPI settings in dhcpd.conf. Issue #10270

History

#1 Updated by Jim Pingle 11 months ago

  • Target version set to 2.5.0

#2 Updated by Jim Pingle 11 months ago

From my comments on that thread (slightly edited to make sense here):

It's using a variable set inside the per-interface foreach outside of the foreach, so the results may be unpredictable depending on whether it's set on the last interface or not. It's trying to take a per-interface setting and trying to apply it globally.

The code right above that for disableauthoritative and alwaysbroadcast has the same problem.

There is an open request to make a dedicated settings tab at #5080 which may be the end result here, though the items mentioned on that issue are not all relevant or likely to happen in this release.

#3 Updated by Steve Beaver 4 months ago

  • Assignee set to Jim Pingle

#5 Updated by Renato Botelho 3 months ago

  • Status changed from New to Feedback

PR has been merged. Thanks!

#6 Updated by Danilo Zrenjanin 2 months ago

  • Status changed from Feedback to Resolved

Tested on:

2.5.0-DEVELOPMENT (amd64)
built on Fri Nov 13 19:02:04 EST 2020
FreeBSD 12.2-STABLE

It looks good now.

sockstat | grep 7911
dhcpd    dhcpd      57562 9  tcp4   *:7911                *:*

Ticket resolved.

Also available in: Atom PDF