Project

General

Profile

Actions
Copy link

Bug #10295

closed

Unescaped characters in dhcp-client-identifier prevent DHCPD from starting on interface

Added by Chris Linstruth almost 5 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Renato Botelho
Category:
DHCP (IPv4)
Target version:
2.5.0
Start date:
02/26/2020
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.4.5
Affected Architecture:

Description

The following is allowed by the webgui in a static mapping: Client Identifier: 32" Sony Trinitron

That creates a configuration that cannot be loaded:

host s_lan_0 {
        hardware ethernet 01:02:03:04:05:06;
        option dhcp-client-identifier "32" Sony Trinitron";
    option host-name "32-Sony";
    option domain-name-servers 172.25.228.1;
}
Actions
Copy link
 #1

Updated by Viktor Gurov almost 5 years ago

This fix replaces the double quote character with '&quot':
https://github.com/pfsense/pfsense/pull/4211

There is no issue with other special characters (',./!@#$%^&*()~)

Actions
Copy link
 #2

Updated by Jim Pingle over 4 years ago

  • Status changed from New to Pull Request Review
  • Target version set to 2.5.0
Actions
Copy link
 #3

Updated by Renato Botelho over 4 years ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Renato Botelho
  • % Done changed from 0 to 100

PR has been merged. Thanks!

Actions
Copy link
 #4

Updated by Viktor Gurov over 4 years ago

  • Status changed from Feedback to Resolved

fine on 2.5.0.a.20200319.0930

Actions
Copy link

Also available in: Atom PDF