Project

General

Profile

Actions

Bug #10386

closed

A NTP Time Server name may only contain the characters a-z, 0-9, '-' and '.'.

Added by Manuel Piovan over 4 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Category:
Web Interface
Target version:
Start date:
03/28/2020
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.5.x
Affected Architecture:

Description

System / General Setup
localization > time server
if it is populated with an ipv6 server you can't save anymore
A NTP Time Server name may only contain the characters a-z, 0-9, '
' and '.'.

Actions #1

Updated by Manuel Piovan over 4 years ago

Manuel Piovan wrote:

System / General Setup
localization -> time server
if it is populated with an ipv6 server you can't save anymore
A NTP Time Server name may only contain the characters a-z, 0-9 ....

PR : https://github.com/pfsense/pfsense/pull/4254

Actions #2

Updated by Jim Pingle over 4 years ago

  • Status changed from New to Pull Request Review
  • Target version set to 2.5.0
Actions #3

Updated by Renato Botelho over 4 years ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Renato Botelho
  • % Done changed from 0 to 100

PR has been merged. Thanks!

Actions #4

Updated by Viktor Gurov over 4 years ago

  • Status changed from Feedback to Resolved

works OK on 2.5.0.a.20200409.0657,

I see an updated and more correct validation code:

if (!is_domain($ts) && (!is_ipaddr($ts))) {
                        $input_errors[] = gettext("NTP Time Server names must be valid domain names, IPv4 addresses, or IPv6 addresses");
}

Actions #5

Updated by Viktor Gurov over 4 years ago

  • Status changed from Resolved to New

same fix for services_ntpd.php:
https://github.com/pfsense/pfsense/pull/4269

Actions #6

Updated by Jim Pingle over 4 years ago

  • Status changed from New to Pull Request Review
Actions #7

Updated by Renato Botelho over 4 years ago

  • Status changed from Pull Request Review to Feedback

PR has been merged. Thanks!

Actions #8

Updated by Viktor Gurov over 4 years ago

  • Status changed from Feedback to Resolved

input validation on 2.5.0.a.20200415.0942 is correct

Actions

Also available in: Atom PDF