Project

General

Profile

Feature #10789

FRR integrated configuration and hitless reloads

Added by Ben Hughes 2 months ago. Updated 1 day ago.

Status:
Pull Request Review
Priority:
Normal
Assignee:
Category:
FRR
Target version:
-
Start date:
07/27/2020
Due date:
% Done:

100%

Estimated time:

Description

Convert FRR to use an integrated configuration file and use frr-reload where possible for hitless configuration changes.

Update frr7 port to 7.4.
Add the frr7-pythontools port to provide frr-reload.py
Refactor the FRR configuration generator to create an integrated configuration file.
3.1. Generated file is in the same format as generated by a vtysh write mem.
Refactor the rc file/generator to use reload unless a service restart is required. (change of enabled daemons).
Accumulate interface descriptions into the FRR configuration for cross-reference to pfSense configuration under vtysh
Include the watchfrr frr watchdog service.

Tested with 2.4.5_p1.

PR: https://github.com/pfsense/FreeBSD-ports/pull/914

History

#1 Updated by Renato Botelho 5 days ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

PR has been merged only on 2.5.0 branch for now so we can get it properly tested

#2 Updated by Steve Wheeler 4 days ago

After upgrading to todays snap with this change I am seeing this error:

PHP Errors:
[22-Sep-2020 14:13:22 Europe/London] PHP Warning:  file_get_contents(/tmp/frr_start_command_last.txt): failed to open stream: No such file or directory in /usr/local/pkg/frr.inc on line 332

The console hung at 'Writing configuration...' at boot after the update requiring me to Ctl+C past it.

The file /tmp/frr_start_command_last.txt does exist once boot is complete but that error is present at every boot.

This system is running a ram disk for /tmp.

#3 Updated by Jim Pingle 4 days ago

Steve Wheeler wrote:

The console hung at 'Writing configuration...' at boot after the update requiring me to Ctl+C past it.

That is likely still #10610 (not yet solved, but affects multiple packages since it's a problem in pkg)

#4 Updated by Ben Hughes 4 days ago

Steve Wheeler wrote:

After upgrading to todays snap with this change I am seeing this error:
[...]

The console hung at 'Writing configuration...' at boot after the update requiring me to Ctl+C past it.

The file /tmp/frr_start_command_last.txt does exist once boot is complete but that error is present at every boot.

This system is running a ram disk for /tmp.

It's a warning rather than an error, so I'd presume it's #10610 as stated. There is a chicken-and-egg situation with the files existence but as I'm preparing another PR with a few small changes/UI fixups and can wrap this in a file_exists call to stop the warning.

#6 Updated by Jim Pingle 1 day ago

  • Status changed from Feedback to Pull Request Review

Also available in: Atom PDF