Project

General

Profile

Bug #10795

WebGUI "Dashboard -> Services Status" widget issue

Added by Mikhail Burichenko about 2 months ago. Updated 8 days ago.

Status:
Resolved
Priority:
Normal
Category:
Dashboard
Target version:
Start date:
07/28/2020
Due date:
% Done:

100%

Estimated time:
Affected Version:
Affected Architecture:
All

Description

If i use FQDN in description of openvpn service, the description line will be truncated after the first dot because:

$service_desc = explode(".",$service['description']);

https://github.com/pfsense/pfsense/blob/master/src/usr/local/www/widgets/widgets/services_status.widget.php
line 103

For example: for desctiption «Tunnel to gw.domain.local» i will see «OpenVPN Server: Tunnel to gw»
If i use several tunnels with same text, but different FQDN (gw.domain1.local, gw.domain2.local, etc) i will see several lines in widget with same description: «OpenVPN Server: Tunnel to gw». It is impossible to understand where what tunnel

I did changed line 103 to:

$service_desc = explode(". ",$service['description']);

Dot + space instead dot only. Because sentences are normally separated by a dot and a space. And now, for example: for description «Tunnel to gw.domain.local. Some huge text...» i will see «OpenVPN Server: Tunnel to gw.domain.local». Only next sentences will be truncated.

Sorry for my English, please.

pfsense_problems_dash_svc_status_1.png (61 KB) pfsense_problems_dash_svc_status_1.png Mikhail Burichenko, 07/28/2020 09:29 AM
Screenshot_2020-09-04 off-gate ipbgd office - VPN OpenVPN Servers.png (11.6 KB) Screenshot_2020-09-04 off-gate ipbgd office - VPN OpenVPN Servers.png Danilo Zrenjanin, 09/04/2020 12:56 PM
Screenshot_2020-09-04 off-gate ipbgd office - Status Dashboard.png (27.7 KB) Screenshot_2020-09-04 off-gate ipbgd office - Status Dashboard.png Danilo Zrenjanin, 09/04/2020 12:56 PM
servicestatus_2_4_5p1.png (56.4 KB) servicestatus_2_4_5p1.png Service Status widget in 2.4.5_1 Max Leighton, 09/13/2020 08:13 PM
servicestatus2_5_0.png (59.1 KB) servicestatus2_5_0.png Service Status widget in 2.5 Max Leighton, 09/13/2020 08:13 PM

Associated revisions

Revision ccbb25fa (diff)
Added by Mikhail Burichenko about 2 months ago

Correct description truncate in "Services Status" widget. Fixes #10795

History

#1 Updated by Jim Pingle about 2 months ago

  • Category set to Dashboard

#2 Updated by Mikhail Burichenko about 2 months ago

Jim Pingle wrote:

Can you submit that change as a pull request on Github?

https://github.com/pfsense/pfsense/pull/4406

#3 Updated by Jim Pingle about 2 months ago

  • Status changed from New to Pull Request Review
  • Target version set to 2.5.0

#4 Updated by Renato Botelho about 1 month ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Renato Botelho
  • % Done changed from 0 to 100

PR has been merged. Thanks!

#5 Updated by Danilo Zrenjanin 17 days ago

I am not sure what versions are affected but I can define OpenVPN description using dots. e.g. <<Tunnel to office.domain.local>> and <<Tunnel to gw.domain.local>>

Tested on:

2.4.5-RELEASE-p1 (arm)
built on Tue Jun 02 17:45:24 EDT 2020
FreeBSD 11.3-STABLE

#6 Updated by Max Leighton 8 days ago

I was able to reproduce using the Service Status widget rather than the OpenVPN widget. The behavior can be seen in 2.4.5_1. The Service Status widget will show the incorrect name, but the OpenVPN widget will show the correct name.

Tested again in:
2.5.0-DEVELOPMENT (amd64)
built on Sun Sep 13 13:04:14 EDT 2020
FreeBSD 12.2-PRERELEASE

And it has been fixed. Resolving the ticket

Also available in: Atom PDF