Bug #10806
closed
armada_thermal fails during device_attach
100%
Description
SG-3100 is unable to read the temperature from sysctl, as the oid doesn't exist, because the driver fails to attach during initialization.
[2.5.0-DEVELOPMENT][root@pfSense.home.lan]/: /sbin/sysctl -aq | grep temperature
*<No results returned>
[2.5.0-DEVELOPMENT][root@pfSense.home.lan]/: dmesg | grep therm
armada_thermal0: <Armada380 Thermal Control> mem 0xe4078-0xe407b,0xe4070-0xe4077 on simplebus1
device_attach: armada_thermal0 attach returned 6
[2.5.0-DEVELOPMENT][root@pfSense.home.lan]/: uname -a
FreeBSD pfSense.home 12.1-STABLE FreeBSD 12.1-STABLE de58b5f9808(factory-devel-12) pfSense-SG-3100 arm
Files
| dmesg.txt (8.63 KB) dmesg.txt | dmesg output | ||
| temp-widgets.png (21 KB) temp-widgets.png |
Updated by Jim Pingle over 3 years ago
- Assignee set to Luiz Souza
- Target version set to 2.5.0
Updated by Luiz Souza over 3 years ago
- Status changed from In Progress to Feedback
- % Done changed from 0 to 100
Fixed.
Please test with the next build.
Updated by Daniel Gordon over 3 years ago
Unfortunately, I've since needed that device and reverted it to 2.4.5. I will be unable to test the change. I'm really curious to see how you fixed it though.
Updated by Luiz Souza over 3 years ago
Daniel Gordon wrote:
Unfortunately, I've since needed that device and reverted it to 2.4.5. I will be unable to test the change. I'm really curious to see how you fixed it though.
https://github.com/pfsense/FreeBSD-src/commit/2d87d8ec46e41aea3ebedcc99b6891f52f73eb6f
I just had to adjust the register offset to cope with a DTS address range change.
Thanks for the report.
Updated by Jordan G over 3 years ago
I'm seeing temps on the dash on
SG-3100
2.5.0-DEVELOPMENT (arm)
built on Sat Dec 05 02:56:23 EST 2020
FreeBSD 12.2-STABLE
looks good!
Updated by Jim Pingle over 3 years ago
- Status changed from Feedback to Resolved
Looks good here, too.
Updated by Jordan G over 3 years ago
- File temp-widgets.png temp-widgets.png added
temp is missing from the separate widget on the dashboard...new issue?
2.5.0-DEVELOPMENT (arm)
built on Sat Dec 12 02:57:13 EST 2020
FreeBSD 12.2-STABLE
Updated by Jim Pingle over 3 years ago
- Status changed from Assigned to Resolved
That would be a separate issue. This was about the hardware error which is OK now.
The temperature is shown in the main system information widget so I'm not sure the separate thermal sensors widget is a concern. Either way that should be its own separate issue.