Project

General

Profile

Actions

Bug #10846

closed

Icon area within buttons are not clickable

Added by Marcos M over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Very Low
Category:
Web Interface
Target version:
Start date:
08/21/2020
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
All
Affected Architecture:

Description

The embedded icon section of buttons are not clickable. See attached for reference.

This seems to only affect the delete buttons within "Firewall / Schedules / Edit", though I'm unsure why.

Adding the following CSS to .icon-embed-btn in pfSense.css fixes it:
pointer-events: none;

Though this fix would affect every part of the web interface, I did not find the bug anywhere else. However, I also did not find any mention of .icon-embed-btn where a pointer-event was used or needed. The pointer events always occurred on the parent of the element (e.g. <a> and <button> elements).


Files

icon.png (8.93 KB) icon.png Marcos M, 08/21/2020 03:32 PM
Actions #1

Updated by Marcos M over 3 years ago

Actions #2

Updated by Marcos M over 3 years ago

  • Affected Version set to All
Actions #3

Updated by Jim Pingle over 3 years ago

  • Status changed from New to Pull Request Review

This issue only seems to affect the delete button on the schedules page. I can't find any other button that won't let me click the icon. And even with the patch from to PR at https://github.com/pfsense/pfsense/pull/4428 applied, I can't click the icon on that one specific button.

Actions #4

Updated by Renato Botelho over 3 years ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Renato Botelho
  • Target version set to 2.5.0
  • % Done changed from 0 to 100

PR has been merged. Thanks!

Actions #5

Updated by Danilo Zrenjanin over 3 years ago

  • Status changed from Feedback to Resolved

Tested on :

2.5.0-DEVELOPMENT (amd64)
built on Thu Sep 17 13:55:47 EDT 2020
FreeBSD 12.2-PRERELEASE

The whole button is clickable.

Ticket resolved.

Actions

Also available in: Atom PDF