Project

General

Profile

Bug #10891

Captive Portal related files are not deleted after deleting CP zone in WebGUI

Added by Viktor Gurov about 1 month ago. Updated 11 days ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Captive Portal
Target version:
Start date:
09/12/2020
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.4.5-p1
Affected Architecture:

Description

If you remove Captive Portal Zone on the services_captiveportal_zones.php page,
related files are still there:
/var/db/captiveportal<zone>.db
/var/db/captiveportal_usedmacs_<zone>.db
/var/db/voucher_<zone>_active_X.db
/var/db/voucher_<zone>_used_X.db

Associated revisions

Revision bf810e13 (diff)
Added by Viktor Gurov about 1 month ago

Delete Captive Portal related files. Fixes #10891

Revision c31f4e95 (diff)
Added by Viktor Gurov 15 days ago

Delete Captive Portal related files on HA node. Fixes #10891

History

#2 Updated by Jim Pingle about 1 month ago

  • Status changed from New to Pull Request Review
  • Target version set to 2.5.0

#3 Updated by Renato Botelho about 1 month ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Renato Botelho
  • % Done changed from 0 to 100

PR has been merged. Thanks!

#4 Updated by Max Leighton 16 days ago

Tested in:

2.5.0-DEVELOPMENT (amd64)
built on Sun Oct 04 18:53:52 EDT 2020
FreeBSD 12.2-STABLE

The captive portal related files were removed from /var/db after deleting the zone from Services>Captive Portal

I tested in an HA pair and saw that the even though the zone gets deleted on the secondary, the /var/db directory on the secondary node kept the files captiveportal_usedmacs, captiveportal_<zone>.db, voucher_<zone>_active_1.db, and voucher_<zone>_used_1.db. Does this need to be addressed?

#5 Updated by Steve Beaver 15 days ago

  • Status changed from Feedback to In Progress

#6 Updated by Renato Botelho 15 days ago

  • Assignee changed from Renato Botelho to Viktor Gurov

Viktor, can you please check this out?

#7 Updated by Viktor Gurov 15 days ago

Max Leighton wrote:

I tested in an HA pair and saw that the even though the zone gets deleted on the secondary, the /var/db directory on the secondary node kept the files captiveportal_usedmacs, captiveportal_<zone>.db, voucher_<zone>_active_1.db, and voucher_<zone>_used_1.db. Does this need to be addressed?

Fix:
https://github.com/pfsense/pfsense/pull/4477

#8 Updated by Renato Botelho 14 days ago

  • Status changed from In Progress to Feedback

PR has been merged. Thanks!

#9 Updated by Max Leighton 11 days ago

  • Status changed from Feedback to Resolved

Tested in

2.5.0-DEVELOPMENT (amd64)
built on Sun Oct 11 13:01:59 EDT 2020
FreeBSD 12.2-STABLE

confirmed that the deleted files were removed from /var/db on the secondary as well. Marking the ticket resolved.

Also available in: Atom PDF