Project

General

Profile

Actions

Bug #10891

closed

Captive Portal related files are not deleted after deleting CP zone in WebGUI

Added by Viktor Gurov over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Viktor Gurov
Category:
Captive Portal
Target version:
Start date:
09/12/2020
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.4.5-p1
Affected Architecture:

Description

If you remove Captive Portal Zone on the services_captiveportal_zones.php page,
related files are still there:
/var/db/captiveportal<zone>.db
/var/db/captiveportal_usedmacs_<zone>.db
/var/db/voucher_<zone>_active_X.db
/var/db/voucher_<zone>_used_X.db

Actions #2

Updated by Jim Pingle over 3 years ago

  • Status changed from New to Pull Request Review
  • Target version set to 2.5.0
Actions #3

Updated by Renato Botelho over 3 years ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Renato Botelho
  • % Done changed from 0 to 100

PR has been merged. Thanks!

Actions #4

Updated by Max Leighton over 3 years ago

Tested in:

2.5.0-DEVELOPMENT (amd64)
built on Sun Oct 04 18:53:52 EDT 2020
FreeBSD 12.2-STABLE

The captive portal related files were removed from /var/db after deleting the zone from Services>Captive Portal

I tested in an HA pair and saw that the even though the zone gets deleted on the secondary, the /var/db directory on the secondary node kept the files captiveportal_usedmacs, captiveportal_<zone>.db, voucher_<zone>_active_1.db, and voucher_<zone>_used_1.db. Does this need to be addressed?

Actions #5

Updated by Anonymous over 3 years ago

  • Status changed from Feedback to In Progress
Actions #6

Updated by Renato Botelho over 3 years ago

  • Assignee changed from Renato Botelho to Viktor Gurov

Viktor, can you please check this out?

Actions #7

Updated by Viktor Gurov over 3 years ago

Max Leighton wrote:

I tested in an HA pair and saw that the even though the zone gets deleted on the secondary, the /var/db directory on the secondary node kept the files captiveportal_usedmacs, captiveportal_<zone>.db, voucher_<zone>_active_1.db, and voucher_<zone>_used_1.db. Does this need to be addressed?

Fix:
https://github.com/pfsense/pfsense/pull/4477

Actions #8

Updated by Renato Botelho over 3 years ago

  • Status changed from In Progress to Feedback

PR has been merged. Thanks!

Actions #9

Updated by Max Leighton over 3 years ago

  • Status changed from Feedback to Resolved

Tested in

2.5.0-DEVELOPMENT (amd64)
built on Sun Oct 11 13:01:59 EDT 2020
FreeBSD 12.2-STABLE

confirmed that the deleted files were removed from /var/db on the secondary as well. Marking the ticket resolved.

Actions

Also available in: Atom PDF