Actions
Bug #11050
closed
"Backup extra data" does not behave properly
Start date:
11/09/2020
Due date:
% Done:
0%
Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.5.0
Affected Architecture:
Description
When backup up with "Backup Extra Data" checked, there are a few problems:
- Tags are not removed during every restore path (e.g. PFI during installer as with #7634 for RRD, ECL, or
restore_backup()in general), so they may remain in config.xml indefinitely - Duplicate tags are not removed on restore as is done for rrddata
- Error when restoring a config generated after backup, restore, then backup again due to the duplicated tags (Like #8994 for RRD)
- Backup Extra Data defaults to on, should be off.
Updated by Viktor Gurov over 3 years ago
Updated by Renato Botelho over 3 years ago
- Status changed from Confirmed to Pull Request Review
- Assignee set to Viktor Gurov
Updated by Jim Pingle over 3 years ago
The PR Addresses the last three points but not the first.
Part of the first one will need fixed in the src repo in the installer, like https://gitlab.netgate.com/pfSense/FreeBSD-src/-/commit/b76e6a64c0b948808a0260f4ce702f2e8866de86
The ECL method (https://gitlab.netgate.com/pfSense/pfSense/-/blob/master/src/etc/ecl.php) will need to be changed as well so it's similar to restoring from the GUI
Updated by Viktor Gurov over 3 years ago
Updated by Renato Botelho over 3 years ago
Updated by Renato Botelho over 3 years ago
- Status changed from Pull Request Review to Feedback
PR has been merged. Thanks!
Updated by Max Leighton over 3 years ago
- Status changed from Feedback to Resolved
Tested in a recent build and am seeing that the extra data is being cleared. No duplicate tags are present on second restore since the tags are cleared after the initial restore.
Actions