"Backup extra data" does not behave properly
When backup up with "Backup Extra Data" checked, there are a few problems:
- Tags are not removed during every restore path (e.g. PFI during installer as with #7634 for RRD, ECL, or
restore_backup()in general), so they may remain in config.xml indefinitely
- Duplicate tags are not removed on restore as is done for rrddata
- Error when restoring a config generated after backup, restore, then backup again due to the duplicated tags (Like #8994 for RRD)
- Backup Extra Data defaults to on, should be off.
#3 Updated by Jim Pingle 5 months ago
The PR Addresses the last three points but not the first.
Part of the first one will need fixed in the src repo in the installer, like https://gitlab.netgate.com/pfSense/FreeBSD-src/-/commit/b76e6a64c0b948808a0260f4ce702f2e8866de86
The ECL method (https://gitlab.netgate.com/pfSense/pfSense/-/blob/master/src/etc/ecl.php) will need to be changed as well so it's similar to restoring from the GUI
#4 Updated by Viktor Gurov 5 months ago
#5 Updated by Renato Botelho 5 months ago
Viktor Gurov wrote: