Project

General

Profile

Bug #11091

Interfaces set as disabled in the configuration have an UP status in the operating system at boot

Added by Viktor Gurov 7 months ago. Updated about 1 month ago.

Status:
New
Priority:
Normal
Assignee:
Viktor Gurov
Category:
Interfaces
Target version:
2.6.0
Start date:
11/21/2020
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
21.09
Release Notes:
Default
Affected Version:
2.5.0
Affected Architecture:

Description

If you disable interface on interfaces.php page it's disabled
there is no UP in ifconfig output and `get_interface_info()` returns 'status' = 'down', 'enable' = 'false'

but after system reboot interface status is UP in ifconfig output and `get_interface_info()` returns 'status' = 'up', 'enable' = 'false', which is incorrect

it seems `interfaces_configure()` doesn't disable interfaces on boot

Associated revisions

Revision 9115501d (diff)
Added by Viktor Gurov 4 months ago

Down disabled interfaces on boot. Fixes #11091

Revision b0f77980 (diff)
Added by Viktor Gurov 3 months ago

Down disabled interfaces on boot. Fixes #11091

(cherry picked from commit 9115501d6ab5197d9caf499e90779c020d711dca)

Revision 3c4fc240 (diff)
Added by Jim Pingle 3 months ago

Revert changes for issue #11091

Negatively impacts parent interfaces, needs more work.

Revision a33c0d88 (diff)
Added by Jim Pingle about 1 month ago

Revert changes for issue #11091

History

#2 Updated by Jim Pingle 7 months ago

  • Status changed from New to Pull Request Review
  • Target version set to CE-Next

#3 Updated by Renato Botelho 4 months ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Viktor Gurov

PR has been merged. Thanks!

#4 Updated by Viktor Gurov 4 months ago

  • % Done changed from 0 to 100

#5 Updated by Jim Pingle 3 months ago

  • Status changed from Feedback to Waiting on Merge
  • Target version changed from CE-Next to 2.5.1

#6 Updated by Renato Botelho 3 months ago

  • Status changed from Waiting on Merge to Feedback

Cherry-picked to RELENG_2_5_1

#7 Updated by Alhusein Zawi 3 months ago

After reboot the interface is not UP in ipconfig

[2.5.1-RC][]/root: ifconfig em2

em2: flags=8802<BROADCAST,SIMPLEX,MULTICAST> metric 0 mtu 1500
options=81009b<RXCSUM,TXCSUM,VLAN_MTU,VLAN_HWTAGGING,VLAN_HWCSUM,VLAN_HW

2.5.1-RC (amd64)
built on Thu Mar 11 09:11:02 EST 2021

#8 Updated by Jim Pingle 3 months ago

  • Status changed from Feedback to Resolved

#9 Updated by Jim Pingle 3 months ago

  • Subject changed from Disabled interface is UP on boot to Interfaces set as disabled in the configuration have an UP status in the operating system at boot

Updating subject for release notes.

#10 Updated by Jim Pingle 3 months ago

  • Status changed from Resolved to In Progress

I think this may need some refinement as it could interfere with other things. If you have an interface assigned but disabled and use that interface as a parent for other things, the children will be affected.

For example if lagg0 is assigned and enabled, and you have VLAN children on lagg0, this takes out the VLAN children.

I think we should back this out of 2.5.1/21.02.2 and work on it more in master for the next release.

#11 Updated by Jim Pingle 3 months ago

  • Target version changed from 2.5.1 to 2.6.0

I backed the change out of RELENG_2_5_1, moving target forward.

#12 Updated by Jim Pingle 3 months ago

  • % Done changed from 100 to 50

#13 Updated by Steve Wheeler 2 months ago

Confirmed; this breaks sub-interfaces on anything that is assigned but disabled by removing the parent entirely.

#14 Updated by Viktor Gurov about 1 month ago

Steve Wheeler wrote:

Confirmed; this breaks sub-interfaces on anything that is assigned but disabled by removing the parent entirely.

fix:
https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/250

#15 Updated by Jim Pingle about 1 month ago

We can bring in that fix for the next release, I backed out the original change from plus-RELENG_21_05 to make sure it doesn't impact the pending release to be safe.

#16 Updated by Jim Pingle about 1 month ago

  • Plus Target Version set to 21.09

#17 Updated by Jim Pingle about 1 month ago

  • Status changed from In Progress to New
  • % Done changed from 50 to 0

Per discussion on the PR, all the changes have been reverted.

Can try alternate approaches for the next release.

Also available in: Atom PDF