Project

General

Profile

Actions
Copy link

Bug #11091

closed

Interfaces set as disabled in the configuration have an UP status in the operating system at boot

Added by Viktor Gurov about 4 years ago. Updated about 2 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
-
Category:
Interfaces
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:
Default
Affected Version:
2.5.0
Affected Architecture:

Description

If you disable interface on interfaces.php page it's disabled
there is no UP in ifconfig output and `get_interface_info()` returns 'status' = 'down', 'enable' = 'false'

but after system reboot interface status is UP in ifconfig output and `get_interface_info()` returns 'status' = 'up', 'enable' = 'false', which is incorrect

it seems `interfaces_configure()` doesn't disable interfaces on boot

Actions
Copy link
 #2

Updated by Jim Pingle about 4 years ago

  • Status changed from New to Pull Request Review
  • Target version set to CE-Next
Actions
Copy link
 #3

Updated by Renato Botelho almost 4 years ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Viktor Gurov

PR has been merged. Thanks!

Actions
Copy link
 #4

Updated by Viktor Gurov almost 4 years ago

  • % Done changed from 0 to 100
Actions
Copy link
 #5

Updated by Jim Pingle over 3 years ago

  • Status changed from Feedback to Waiting on Merge
  • Target version changed from CE-Next to 2.5.1
Actions
Copy link
 #6

Updated by Renato Botelho over 3 years ago

  • Status changed from Waiting on Merge to Feedback

Cherry-picked to RELENG_2_5_1

Actions
Copy link
 #7

Updated by Alhusein Zawi over 3 years ago

After reboot the interface is not UP in ipconfig

[2.5.1-RC][]/root: ifconfig em2

em2: flags=8802<BROADCAST,SIMPLEX,MULTICAST> metric 0 mtu 1500
options=81009b<RXCSUM,TXCSUM,VLAN_MTU,VLAN_HWTAGGING,VLAN_HWCSUM,VLAN_HW

2.5.1-RC (amd64)
built on Thu Mar 11 09:11:02 EST 2021

Actions
Copy link
 #8

Updated by Jim Pingle over 3 years ago

  • Status changed from Feedback to Resolved
Actions
Copy link
 #9

Updated by Jim Pingle over 3 years ago

  • Subject changed from Disabled interface is UP on boot to Interfaces set as disabled in the configuration have an UP status in the operating system at boot

Updating subject for release notes.

Actions
Copy link
 #10

Updated by Jim Pingle over 3 years ago

  • Status changed from Resolved to In Progress

I think this may need some refinement as it could interfere with other things. If you have an interface assigned but disabled and use that interface as a parent for other things, the children will be affected.

For example if lagg0 is assigned and enabled, and you have VLAN children on lagg0, this takes out the VLAN children.

I think we should back this out of 2.5.1/21.02.2 and work on it more in master for the next release.

Actions
Copy link
 #11

Updated by Jim Pingle over 3 years ago

  • Target version changed from 2.5.1 to 2.6.0

I backed the change out of RELENG_2_5_1, moving target forward.

Actions
Copy link
 #12

Updated by Jim Pingle over 3 years ago

  • % Done changed from 100 to 50
Actions
Copy link
 #13

Updated by Steve Wheeler over 3 years ago

Confirmed; this breaks sub-interfaces on anything that is assigned but disabled by removing the parent entirely.

Actions
Copy link
 #14

Updated by Viktor Gurov over 3 years ago

Steve Wheeler wrote:

Confirmed; this breaks sub-interfaces on anything that is assigned but disabled by removing the parent entirely.

fix:
https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/250

Actions
Copy link
 #15

Updated by Jim Pingle over 3 years ago

We can bring in that fix for the next release, I backed out the original change from plus-RELENG_21_05 to make sure it doesn't impact the pending release to be safe.

Actions
Copy link
 #16

Updated by Jim Pingle over 3 years ago

  • Plus Target Version set to 21.09
Actions
Copy link
 #17

Updated by Jim Pingle over 3 years ago

  • Status changed from In Progress to New
  • % Done changed from 50 to 0

Per discussion on the PR, all the changes have been reverted.

Can try alternate approaches for the next release.

Actions
Copy link
 #18

Updated by Jim Pingle over 3 years ago

  • Plus Target Version changed from 21.09 to 22.01

Moving ahead, too close to release to make another attempt at this and have enough time to validate the change in behavior.

Actions
Copy link
 #19

Updated by Jim Pingle about 3 years ago

  • Target version changed from 2.6.0 to CE-Next
  • Plus Target Version changed from 22.01 to 22.05
Actions
Copy link
 #20

Updated by Jim Pingle over 2 years ago

  • Plus Target Version changed from 22.05 to 22.09
Actions
Copy link
 #21

Updated by Jim Pingle over 2 years ago

  • Plus Target Version changed from 22.09 to 22.11
Actions
Copy link
 #22

Updated by Jim Pingle about 2 years ago

  • Plus Target Version changed from 22.11 to 23.01
Actions
Copy link
 #23

Updated by Jim Pingle about 2 years ago

  • Assignee deleted (Viktor Gurov)
Actions
Copy link
 #24

Updated by Jim Pingle about 2 years ago

  • Status changed from New to Rejected
  • Target version deleted (CE-Next)
  • Start date deleted (11/21/2020)
  • Plus Target Version deleted (23.01)

No movement in a long time on this plus when we did try it was really disruptive for little to no benefit. Closing for now, we can always revisit it in the future.

Actions
Copy link

Also available in: Atom PDF