Project

General

Profile

Actions
Copy link

Bug #11877

closed

Labels and description disappear in firewall_schedule_edit.php

Added by Marcos M over 3 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
Very Low
Assignee:
Christian McDonald
Category:
Rules / NAT
Target version:
2.7.0
Start date:
05/02/2021
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
23.05
Release Notes:
Force Exclusion
Affected Version:
2.5.1
Affected Architecture:

Description

  1. Add a new entry under Firewall / Schedules
  2. Select a date
  3. Click "Add Time"
  4. The labels and description on the "Time" field are now hidden

Files

Download all files
before.png (15.9 KB) before.png Marcos M, 05/02/2021 03:56 PM
after.png (13.6 KB) after.png Marcos M, 05/02/2021 03:56 PM
Actions
Copy link
 #2

Updated by Jim Pingle over 3 years ago

  • Status changed from New to Pull Request Review
  • Target version set to 2.6.0
Actions
Copy link
 #3

Updated by Marcos M over 3 years ago

I think the original reason to hide it through .help-block was to avoid cluttering the "Configured Ranges" section. Removing the hide statement completely will not take this into account. Instead of removing it, it may be best to have a more specific element selector.

Actions
Copy link
 #4

Updated by Jim Pingle about 3 years ago

  • Plus Target Version set to 22.01
Actions
Copy link
 #5

Updated by Jim Pingle almost 3 years ago

  • Assignee set to Viktor Gurov
  • Target version changed from 2.6.0 to CE-Next
  • Plus Target Version changed from 22.01 to 22.05
Actions
Copy link
 #6

Updated by Jim Pingle over 2 years ago

  • Plus Target Version changed from 22.05 to 22.09
Actions
Copy link
 #7

Updated by Jim Pingle over 2 years ago

  • Plus Target Version changed from 22.09 to 22.11
Actions
Copy link
 #8

Updated by Jim Pingle about 2 years ago

  • Plus Target Version changed from 22.11 to 23.01
Actions
Copy link
 #9

Updated by Jim Pingle about 2 years ago

  • Assignee deleted (Viktor Gurov)
Actions
Copy link
 #10

Updated by Jim Pingle about 2 years ago

  • Plus Target Version changed from 23.01 to 23.05
Actions
Copy link
 #11

Updated by Christian McDonald almost 2 years ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Christian McDonald
Actions
Copy link
 #12

Updated by Christian McDonald almost 2 years ago

Reapplied the patch. I was unable to rebase in GitLab.

Feedback now appreciated.

Actions
Copy link
 #13

Updated by Jim Pingle almost 2 years ago

  • Category changed from Web Interface to Rules / NAT
  • Target version changed from CE-Next to 2.7.0
Actions
Copy link
 #14

Updated by Lev Prokofev almost 2 years ago

Tested on 23.01, It still disappears descriptions and labels.

Actions
Copy link
 #15

Updated by Jim Pingle almost 2 years ago

  • Status changed from Feedback to New
Actions
Copy link
 #16

Updated by Christian McDonald almost 2 years ago

  • Status changed from New to Feedback

Right. The fix is in snapshots.

Actions
Copy link
 #17

Updated by Marcos M almost 2 years ago

  • Status changed from Feedback to Resolved

There's a quirk with the fix where removing the row with the labels does not re-add the labels until the changes are saved and the page refreshed. The original issue is resolved however.

Actions
Copy link
 #18

Updated by Marcos M almost 2 years ago

  • Release Notes changed from Default to Force Exclusion
Actions
Copy link
 #19

Updated by Marcos M almost 2 years ago

  • Subject changed from Labels and description dissapear in firewall_schedule_edit.php to Labels and description disappear in firewall_schedule_edit.php
Actions
Copy link

Also available in: Atom PDF