Bug #11946
closed
Custom value for AutoConfigBackup schedule Hours is not shown when loading the settings page
Added by Jim Pingle over 3 years ago.
Updated about 3 years ago.
Category:
Backup / Restore
Plus Target Version:
22.01
Description
When ACB is set to use a schedule on services_acb_settings.php
, a the hour value from config.xml is not populated on the page. It always loads at 0
. The correct value is placed into config.xml and is used as expected, but it is not shown to the user on the page.
If the user is not careful, the next time they visit the page to make a change, their chosen hour will reset to 0 unless they re-add their custom value.
Jim Pingle wrote:
When ACB is set to use a schedule on services_acb_settings.php
, a the hour value from config.xml is not populated on the page. It always loads at 0
. The correct value is placed into config.xml and is used as expected, but it is not shown to the user on the page.
If the user is not careful, the next time they visit the page to make a change, their chosen hour will reset to 0 unless they re-add their custom value.
I reproduced this.
- Status changed from New to Pull Request Review
- Status changed from Pull Request Review to Feedback
- Assignee set to Viktor Gurov
PR has been merged. Thanks!
Tested in 2.6.0. The specified hour will now stay on the page when after navigating away and navigating back.
However, I'm still seeing this in
21.09-DEVELOPMENT (arm64)
built on Sat Jun 05 01:09:01 EDT 2021
FreeBSD 12.2-STABLE
Cherry-picked to 2.5.2-RC
- Status changed from Feedback to Closed
Works with the latest RELENG_2_5_2 code in place.
- Subject changed from AutoConfigBackup schedule custom hour value lost on page load to Custom value for AutoConfigBackup schedule Hours is not shown when loading the settings page
Updating subject for release notes.
- Plus Target Version changed from 21.09 to 22.01
Also available in: Atom
PDF