Project

General

Profile

Actions
Copy link

Todo #11976

closed

Compliance with pfSense style guide in Dynamic DNS service code

Added by Jaakko Kantojärvi over 3 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority:
Low
Assignee:
Renato Botelho
Category:
Dynamic DNS
Target version:
2.6.0
Start date:
05/29/2021
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
22.01
Release Notes:
Force Exclusion

Description

Files for the dynamic DNS include white space in the end of lines.

Additionally, many switch statements list providers in a random order and there is no clear instructions about where a new provider should be added (in alphabetical order or append in the end).

Fix: https://github.com/pfsense/pfsense/pull/4523

Actions
Copy link
 #1

Updated by Jim Pingle over 3 years ago

  • Tracker changed from Bug to Todo
  • Subject changed from Compliance with pfSense style guide in dynamic DNS service code to Compliance with pfSense style guide in Dynamic DNS service code
  • Target version set to 2.6.0
  • Plus Target Version set to 21.09
Actions
Copy link
 #2

Updated by Jim Pingle over 3 years ago

  • Status changed from New to Pull Request Review
Actions
Copy link
 #3

Updated by Renato Botelho over 3 years ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Renato Botelho

PR has been merged. Thanks!

Actions
Copy link
 #4

Updated by Jim Pingle over 3 years ago

  • Release Notes changed from Default to Force Exclusion

No need to include this in release notes

Actions
Copy link
 #5

Updated by Jim Pingle about 3 years ago

  • Plus Target Version changed from 21.09 to 22.01
Actions
Copy link
 #6

Updated by Jim Pingle almost 3 years ago

  • Status changed from Feedback to Resolved
Actions
Copy link

Also available in: Atom PDF