Project

General

Profile

Actions

Bug #12003

open

Pie and fq_pie in /etc/inc/shaper.inc doesn't handle floating point numbers and is applying invalid settings to the pie aqm and scheduler. It is also missing many of the pie settings.

Added by Harley Peters about 2 months ago. Updated about 1 month ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Traffic Shaper (Limiters)
Target version:
-
Start date:
06/07/2021
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:
Default
Affected Version:
Affected Architecture:

Description

Example:
"alpha" => array("name" => "alpha", "type" => "number", "default" => get_single_sysctl("net.inet.ip.dummynet.fqpie.alpha")),
This returns and sets a default value of 125 it is supposed to be .125.

This is what it should be:
"alpha" => array("name" => "alpha", "type" => "number step=any", "default" => intval(get_single_sysctl("net.inet.ip.dummynet.fqpie.alpha")) / 1000),

I have attached a patch which fixes this and adds all the missing settings for the pie AQM and Scheduler.


Files

shaper.patch (13.5 KB) shaper.patch Harley Peters, 06/07/2021 07:42 AM
shaper-v2.patch (13.5 KB) shaper-v2.patch Harley Peters, 06/09/2021 04:47 PM
shaper-v3.patch (14 KB) shaper-v3.patch Harley Peters, 06/11/2021 12:36 PM
shaper-full-v4.patch (14.7 KB) shaper-full-v4.patch Harley Peters, 06/29/2021 12:54 PM
shaper-pie-001.patch (12.7 KB) shaper-pie-001.patch Harley Peters, 06/29/2021 12:54 PM
shaper-allow-zero-002.patch (452 Bytes) shaper-allow-zero-002.patch Harley Peters, 06/29/2021 12:54 PM
shaper-ecn-003.patch (2.55 KB) shaper-ecn-003.patch Harley Peters, 06/29/2021 12:54 PM
Actions #1

Updated by Jim Pingle about 2 months ago

  • Target version deleted (2.6.0)
Actions #2

Updated by Harley Peters about 2 months ago

Patch version 2.
Fixed a spelling problem with the derand setting.

Actions #3

Updated by Harley Peters about 2 months ago

Patch version 3.

Added the ability to set the AQM & Scheduler parameters to zero.
Before php would interpet a zero as null and would set the default instead.
I use this on at least one of the pie parameters.

Actions #4

Updated by Harley Peters about 1 month ago

Patch version 4.
shaper-full-v4.patch

Broken up into seperate patches.

shaper-pie-001.patch
Necessary to get the pie aqm and fq_pie scheduler to work proberly.

shaper-allow-zero-002.patch
Allows entering zero as a parameter value in both aqm and schedulers.

shaper-ecn-003.patch.
Makes it so the ecn checkbox doesn't show up when the aqm or scheduler doesn't support it.
And removes the aqm and scheduler warning about not supporting ecn.

Actions

Also available in: Atom PDF