Bug #12003
closedPie and ``fq_pie`` are missing options and do not handle floating point number input correctly
0%
Description
Example:
"alpha" => array("name" => "alpha", "type" => "number", "default" => get_single_sysctl("net.inet.ip.dummynet.fqpie.alpha")),
This returns and sets a default value of 125 it is supposed to be .125.
This is what it should be:
"alpha" => array("name" => "alpha", "type" => "number step=any", "default" => intval(get_single_sysctl("net.inet.ip.dummynet.fqpie.alpha")) / 1000),
I have attached a patch which fixes this and adds all the missing settings for the pie AQM and Scheduler.
Files
Updated by Anonymous over 3 years ago
- File shaper-v2.patch shaper-v2.patch added
Patch version 2.
Fixed a spelling problem with the derand setting.
Updated by Anonymous over 3 years ago
- File shaper-v3.patch shaper-v3.patch added
Patch version 3.
Added the ability to set the AQM & Scheduler parameters to zero.
Before php would interpet a zero as null and would set the default instead.
I use this on at least one of the pie parameters.
Updated by Anonymous over 3 years ago
- File shaper-full-v4.patch shaper-full-v4.patch added
- File shaper-pie-001.patch shaper-pie-001.patch added
- File shaper-allow-zero-002.patch shaper-allow-zero-002.patch added
- File shaper-ecn-003.patch shaper-ecn-003.patch added
Patch version 4.
shaper-full-v4.patch
Broken up into seperate patches.
shaper-pie-001.patch
Necessary to get the pie aqm and fq_pie scheduler to work proberly.
shaper-allow-zero-002.patch
Allows entering zero as a parameter value in both aqm and schedulers.
shaper-ecn-003.patch.
Makes it so the ecn checkbox doesn't show up when the aqm or scheduler doesn't support it.
And removes the aqm and scheduler warning about not supporting ecn.
Updated by Viktor Gurov about 3 years ago
Please create a pull request:
https://docs.netgate.com/pfsense/en/latest/development/pull-request.html
Updated by Viktor Gurov almost 3 years ago
Updated by Anonymous almost 3 years ago
- File shaper-v5-full.patch shaper-v5-full.patch added
Latest patch fixes some fq_pie setting showing up in none fq_pie limiters.
Updated by Anonymous almost 3 years ago
Updated by Jim Pingle almost 3 years ago
- Status changed from New to Pull Request Review
- Target version set to CE-Next
- Plus Target Version set to 22.05
Updated by Viktor Gurov almost 3 years ago
- Status changed from Pull Request Review to Feedback
Updated by Jim Pingle almost 3 years ago
- Target version changed from CE-Next to 2.7.0
Updated by Jim Pingle over 2 years ago
- Subject changed from Pie and fq_pie in /etc/inc/shaper.inc doesn't handle floating point numbers and is applying invalid settings to the pie aqm and scheduler. It is also missing many of the pie settings. to Pie and ``fq_pie`` are missing options and do not handle floating point number input correctly
Updating subject for release notes.
Updated by Reid Linnemann over 2 years ago
- Status changed from Feedback to Resolved