Project

General

Profile

Actions
Copy link

Bug #12003

closed

Pie and ``fq_pie`` are missing options and do not handle floating point number input correctly

Added by Anonymous almost 3 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Traffic Shaper (Limiters)
Target version:
2.7.0
Start date:
06/07/2021
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
22.05
Release Notes:
Default
Affected Version:
Affected Architecture:

Description

Example:
"alpha" => array("name" => "alpha", "type" => "number", "default" => get_single_sysctl("net.inet.ip.dummynet.fqpie.alpha")),
This returns and sets a default value of 125 it is supposed to be .125.

This is what it should be:
"alpha" => array("name" => "alpha", "type" => "number step=any", "default" => intval(get_single_sysctl("net.inet.ip.dummynet.fqpie.alpha")) / 1000),

I have attached a patch which fixes this and adds all the missing settings for the pie AQM and Scheduler.

Files

Download all files
shaper.patch (13.5 KB) shaper.patch Anonymous, 06/07/2021 07:42 AM
shaper-v2.patch (13.5 KB) shaper-v2.patch Anonymous, 06/09/2021 04:47 PM
shaper-v3.patch (14 KB) shaper-v3.patch Anonymous, 06/11/2021 12:36 PM
shaper-full-v4.patch (14.7 KB) shaper-full-v4.patch Anonymous, 06/29/2021 12:54 PM
shaper-pie-001.patch (12.7 KB) shaper-pie-001.patch Anonymous, 06/29/2021 12:54 PM
shaper-allow-zero-002.patch (452 Bytes) shaper-allow-zero-002.patch Anonymous, 06/29/2021 12:54 PM
shaper-ecn-003.patch (2.55 KB) shaper-ecn-003.patch Anonymous, 06/29/2021 12:54 PM
shaper-v5-full.patch (15.1 KB) shaper-v5-full.patch Anonymous, 12/19/2021 09:23 PM
Actions
Copy link

Also available in: Atom PDF