Project

General

Profile

Actions
Copy link

Bug #12003

closed

Pie and ``fq_pie`` are missing options and do not handle floating point number input correctly

Added by Anonymous over 3 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Traffic Shaper (Limiters)
Target version:
2.7.0
Start date:
06/07/2021
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
22.05
Release Notes:
Default
Affected Version:
Affected Architecture:

Description

Example:
"alpha" => array("name" => "alpha", "type" => "number", "default" => get_single_sysctl("net.inet.ip.dummynet.fqpie.alpha")),
This returns and sets a default value of 125 it is supposed to be .125.

This is what it should be:
"alpha" => array("name" => "alpha", "type" => "number step=any", "default" => intval(get_single_sysctl("net.inet.ip.dummynet.fqpie.alpha")) / 1000),

I have attached a patch which fixes this and adds all the missing settings for the pie AQM and Scheduler.

Files

Download all files
shaper.patch (13.5 KB) shaper.patch Anonymous, 06/07/2021 07:42 AM
shaper-v2.patch (13.5 KB) shaper-v2.patch Anonymous, 06/09/2021 04:47 PM
shaper-v3.patch (14 KB) shaper-v3.patch Anonymous, 06/11/2021 12:36 PM
shaper-full-v4.patch (14.7 KB) shaper-full-v4.patch Anonymous, 06/29/2021 12:54 PM
shaper-pie-001.patch (12.7 KB) shaper-pie-001.patch Anonymous, 06/29/2021 12:54 PM
shaper-allow-zero-002.patch (452 Bytes) shaper-allow-zero-002.patch Anonymous, 06/29/2021 12:54 PM
shaper-ecn-003.patch (2.55 KB) shaper-ecn-003.patch Anonymous, 06/29/2021 12:54 PM
shaper-v5-full.patch (15.1 KB) shaper-v5-full.patch Anonymous, 12/19/2021 09:23 PM
Actions
Copy link
 #1

Updated by Jim Pingle over 3 years ago

  • Target version deleted (2.6.0)
Actions
Copy link
 #2

Updated by Anonymous over 3 years ago

Patch version 2.
Fixed a spelling problem with the derand setting.

Actions
Copy link
 #3

Updated by Anonymous over 3 years ago

Patch version 3.

Added the ability to set the AQM & Scheduler parameters to zero.
Before php would interpet a zero as null and would set the default instead.
I use this on at least one of the pie parameters.

Actions
Copy link
 #4

Updated by Anonymous over 3 years ago

Patch version 4.
shaper-full-v4.patch

Broken up into seperate patches.

shaper-pie-001.patch
Necessary to get the pie aqm and fq_pie scheduler to work proberly.

shaper-allow-zero-002.patch
Allows entering zero as a parameter value in both aqm and schedulers.

shaper-ecn-003.patch.
Makes it so the ecn checkbox doesn't show up when the aqm or scheduler doesn't support it.
And removes the aqm and scheduler warning about not supporting ecn.

Actions
Copy link
 #5

Updated by Viktor Gurov almost 3 years ago

Actions
Copy link
 #7

Updated by Anonymous almost 3 years ago

Latest patch fixes some fq_pie setting showing up in none fq_pie limiters.

Actions
Copy link
 #9

Updated by Jim Pingle almost 3 years ago

  • Status changed from New to Pull Request Review
  • Target version set to CE-Next
  • Plus Target Version set to 22.05
Actions
Copy link
 #10

Updated by Viktor Gurov almost 3 years ago

  • Status changed from Pull Request Review to Feedback
Actions
Copy link
 #11

Updated by Jim Pingle over 2 years ago

  • Target version changed from CE-Next to 2.7.0
Actions
Copy link
 #12

Updated by Jim Pingle over 2 years ago

  • Subject changed from Pie and fq_pie in /etc/inc/shaper.inc doesn't handle floating point numbers and is applying invalid settings to the pie aqm and scheduler. It is also missing many of the pie settings. to Pie and ``fq_pie`` are missing options and do not handle floating point number input correctly

Updating subject for release notes.

Actions
Copy link
 #13

Updated by Jim Pingle over 2 years ago

  • Assignee set to Anonymous
Actions
Copy link
 #14

Updated by Reid Linnemann over 2 years ago

  • Status changed from Feedback to Resolved
Actions
Copy link

Also available in: Atom PDF