Project

General

Profile

Actions
Copy link

Regression #12245

closed
SW VG

Input validation error in system.php

Regression #12245: Input validation error in system.php

Added by Steve Wheeler about 5 years ago. Updated almost 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Viktor Gurov
Category:
Web Interface
Target version:
2.6.0
Start date:
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
22.01
Release Notes:
Force Exclusion
Affected Version:
2.6.0
Affected Architecture:
All

Description

The input validation in system.php incorrectly prevents numeric hostnames in 2.6 and 21.09. For example '3100' or '2600'.

This is a regression since 2.5.2 / 21.05

Tested:

21.09-DEVELOPMENT (amd64)
built on Wed Aug 11 01:17:52 EDT 2021
FreeBSD 12.2-STABLE


2.6.0-DEVELOPMENT (amd64)
built on Wed Aug 11 01:15:06 EDT 2021
FreeBSD 12.2-STABLE

Files

Screenshot from 2021-08-11 14-39-54.png (43.8 KB) Screenshot from 2021-08-11 14-39-54.png Steve Wheeler, 08/11/2021 08:58 AM

Related issues 1 (0 open — 1 closed)

Related to Bug #12000: Remote log server input validation allows invalid valuesResolvedViktor Gurov06/06/2021

Actions

VG Updated by Viktor Gurov about 5 years ago Actions
Copy link
 #1

related to #12000

RB Updated by Renato Botelho about 5 years ago Actions
Copy link
 #2

  • Assignee set to Viktor Gurov

JP Updated by Jim Pingle about 5 years ago Actions
Copy link
 #3

  • Related to Bug #12000: Remote log server input validation allows invalid values added

JP Updated by Jim Pingle about 5 years ago Actions
Copy link
 #5

  • Status changed from New to Pull Request Review

VG Updated by Viktor Gurov about 5 years ago Actions
Copy link
 #6

  • Status changed from Pull Request Review to Feedback

Merged

SW Updated by Steve Wheeler about 5 years ago Actions
Copy link
 #7

This looks good now with that patch. I am able to use numeric hosts names. It still rejects invalid hosts that include the domain name etc.

Waiting to test the new snapshot after the merge.

SW Updated by Steve Wheeler about 5 years ago Actions
Copy link
 #8

  • Status changed from Feedback to Resolved

This is now fixed in snapshots.

Tested:

2.6.0-DEVELOPMENT (amd64)
built on Wed Aug 18 01:08:59 EDT 2021
FreeBSD 12.2-STABLE


21.09-DEVELOPMENT (arm)
built on Wed Aug 18 01:11:54 EDT 2021
FreeBSD 12.2-STABLE

JP Updated by Jim Pingle about 5 years ago Actions
Copy link
 #9

  • Release Notes changed from Default to Force Exclusion

Was a regression introduced after the last release and was never in a release, thus excluding from release notes.

JP Updated by Jim Pingle almost 5 years ago Actions
Copy link
 #10

  • Plus Target Version changed from 21.09 to 22.01
Actions
Copy link

Also available in: Atom