Bug #1243
closed
GUI/Backend code needs updated after multi-PPPoE-server code switch
100%
Description
After creating a PPPoE server a new tab should be displayed at Firewall Rules, but it isn't. Then I can't create rules to allow traffic for PPPoE connections.
Files
Updated by Jim Pingle almost 14 years ago
- Status changed from New to Feedback
- % Done changed from 0 to 100
Applied in changeset 20fef17c7398170e18c9d03bcc04ee794002e981.
Updated by Vinícius Coque almost 14 years ago
- File pppoe.patch pppoe.patch added
Jim P your fix makes the PPPoE tab appear, but the firewall rules are not generated after applying changes. I attached a patch that fix it, can you take a look?
Updated by Jim Pingle almost 14 years ago
- Status changed from Feedback to New
I fixed the places in the GUI that you saw (in a more general way) but the filter.inc changes need more care. What you have there isn't quite right, but I'd need more time with the code to figure out how to do it correctly.
Updated by Jim Pingle almost 14 years ago
- Subject changed from PPPoE tab isn't displayed on firewall rules after creating a PPPoE server to GUI/Backend code needs updated after multi-PPPoE-server code switch
Ermal said he'd have a look at the filter.inc part when he gets a chance. Every other reference to the old style config for a single PPPoE server should be fixed. Once the filter.inc bit is done it should be fine.
Updated by Deon George over 13 years ago
FWIW, the /etc/inc/filter.inc portion of Vinícius Coque's patch fixes my problem of PPPOE rules not being created for the PPPOE Server.
Updated by Jim Pingle over 13 years ago
- Category set to PPPoE Server
- Target version set to 2.0
- % Done changed from 100 to 60
- Affected Architecture All added
- Affected Architecture deleted (
)
Updated by Ermal Luçi over 13 years ago
- Status changed from New to Feedback
- % Done changed from 60 to 100
Applied in changeset ee6d2b525127a05121682b1c26dd153496385b36.
Updated by Chris Buechler over 13 years ago
- Status changed from Feedback to Resolved