GUI/Backend code needs updated after multi-PPPoE-server code switch
After creating a PPPoE server a new tab should be displayed at Firewall Rules, but it isn't. Then I can't create rules to allow traffic for PPPoE connections.
Show PPPoE tab if any of the PPPoE server instances are enabled. Fixes #1243
Generalize pppoe server enabled check and use it elsewhere in the GUI that needed fixed. Still needs changes in filter.inc - Ticket #1243
#3 Updated by Jim Pingle over 8 years ago
- Status changed from Feedback to New
I fixed the places in the GUI that you saw (in a more general way) but the filter.inc changes need more care. What you have there isn't quite right, but I'd need more time with the code to figure out how to do it correctly.
#4 Updated by Jim Pingle over 8 years ago
- Subject changed from PPPoE tab isn't displayed on firewall rules after creating a PPPoE server to GUI/Backend code needs updated after multi-PPPoE-server code switch
Ermal said he'd have a look at the filter.inc part when he gets a chance. Every other reference to the old style config for a single PPPoE server should be fixed. Once the filter.inc bit is done it should be fine.