Project

General

Profile

Actions

Bug #1243

closed

GUI/Backend code needs updated after multi-PPPoE-server code switch

Added by Vinícius Coque almost 11 years ago. Updated over 10 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
PPPoE Server
Target version:
Start date:
01/31/2011
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.0
Affected Architecture:
All

Description

After creating a PPPoE server a new tab should be displayed at Firewall Rules, but it isn't. Then I can't create rules to allow traffic for PPPoE connections.


Files

pppoe.patch (5.54 KB) pppoe.patch Vinícius Coque, 02/01/2011 12:07 PM
Actions #1

Updated by Jim Pingle almost 11 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100
Actions #2

Updated by Vinícius Coque almost 11 years ago

Jim P your fix makes the PPPoE tab appear, but the firewall rules are not generated after applying changes. I attached a patch that fix it, can you take a look?

Actions #3

Updated by Jim Pingle almost 11 years ago

  • Status changed from Feedback to New

I fixed the places in the GUI that you saw (in a more general way) but the filter.inc changes need more care. What you have there isn't quite right, but I'd need more time with the code to figure out how to do it correctly.

Actions #4

Updated by Jim Pingle almost 11 years ago

  • Subject changed from PPPoE tab isn't displayed on firewall rules after creating a PPPoE server to GUI/Backend code needs updated after multi-PPPoE-server code switch

Ermal said he'd have a look at the filter.inc part when he gets a chance. Every other reference to the old style config for a single PPPoE server should be fixed. Once the filter.inc bit is done it should be fine.

Actions #5

Updated by Deon George over 10 years ago

FWIW, the /etc/inc/filter.inc portion of Vinícius Coque's patch fixes my problem of PPPOE rules not being created for the PPPOE Server.

Actions #6

Updated by Jim Pingle over 10 years ago

  • Category set to PPPoE Server
  • Target version set to 2.0
  • % Done changed from 100 to 60
  • Affected Architecture All added
  • Affected Architecture deleted ()
Actions #7

Updated by Ermal Luçi over 10 years ago

  • Status changed from New to Feedback
  • % Done changed from 60 to 100
Actions #8

Updated by Chris Buechler over 10 years ago

  • Status changed from Feedback to Resolved
Actions

Also available in: Atom PDF