Bug #1243
closed
GUI/Backend code needs updated after multi-PPPoE-server code switch
Added by Vinícius Coque about 13 years ago.
Updated over 12 years ago.
Affected Architecture:
All
Description
After creating a PPPoE server a new tab should be displayed at Firewall Rules, but it isn't. Then I can't create rules to allow traffic for PPPoE connections.
Files
- Status changed from New to Feedback
- % Done changed from 0 to 100
Jim P your fix makes the PPPoE tab appear, but the firewall rules are not generated after applying changes. I attached a patch that fix it, can you take a look?
- Status changed from Feedback to New
I fixed the places in the GUI that you saw (in a more general way) but the filter.inc changes need more care. What you have there isn't quite right, but I'd need more time with the code to figure out how to do it correctly.
- Subject changed from PPPoE tab isn't displayed on firewall rules after creating a PPPoE server to GUI/Backend code needs updated after multi-PPPoE-server code switch
Ermal said he'd have a look at the filter.inc part when he gets a chance. Every other reference to the old style config for a single PPPoE server should be fixed. Once the filter.inc bit is done it should be fine.
FWIW, the /etc/inc/filter.inc portion of Vinícius Coque's patch fixes my problem of PPPOE rules not being created for the PPPOE Server.
- Category set to PPPoE Server
- Target version set to 2.0
- % Done changed from 100 to 60
- Affected Architecture All added
- Affected Architecture deleted (
- Status changed from New to Feedback
- % Done changed from 60 to 100
- Status changed from Feedback to Resolved
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by 
Updated by Ermal Luçi 
Updated by