Project

General

Profile

Actions
Copy link

Bug #12649

closed

Allowed IP/Hostname "Direction" option is never used

Added by Viktor Gurov over 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Viktor Gurov
Category:
Captive Portal
Target version:
2.7.0
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
22.05
Release Notes:
Default
Affected Version:
All
Affected Architecture:

Description

The "Direction" (dir in config) is never used in the captiveportal_allowedip_configure_entry():
https://github.com/pfsense/pfsense/blob/master/src/etc/inc/captiveportal.inc#L1469

Looks like legacy / incorrect refactoring code.

In fact, it only confuses users,- what does "From" mean? Why use "To" but not "Both"?

Related issues

Related to Todo #13100: Transition Captive Portal from IPFW to PFResolvedViktor Gurov

Actions
Actions
Copy link
 #2

Updated by Viktor Gurov almost 2 years ago

  • Status changed from New to Feedback
  • Assignee set to Viktor Gurov
  • Target version set to 2.7.0
  • Plus Target Version set to 22.05

Implemented in #13100

Actions
Copy link
 #3

Updated by Viktor Gurov almost 2 years ago

  • Related to Todo #13100: Transition Captive Portal from IPFW to PF added
Actions
Copy link
 #4

Updated by Jim Pingle almost 2 years ago

  • % Done changed from 0 to 100
Actions
Copy link
 #5

Updated by Reid Linnemann almost 2 years ago

  • Status changed from Feedback to Closed
Actions
Copy link

Also available in: Atom PDF