Project

General

Profile

Actions

Bug #12759

open

Proprietary packages link to non-existant or non-public github pages

Added by Kris Phillips over 2 years ago. Updated about 10 hours ago.

Status:
New
Priority:
Very Low
Assignee:
-
Category:
Package System
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Release Notes:
Default
Affected Plus Version:
22.01
Affected Architecture:
All

Description

When clicking on the version number to view the code for packages like openvpn-import and aws-wizard, these link to a non-existant Github page (or one that is private). We should probably add a way to just remove these links on proprietary packages for pfSense Plus.

For example, aws-wizard links to https://github.com/pfsense/FreeBSD-ports/commits/devel/net/pfSense-pkg-aws-wizard which is an invalid path.

Actions #1

Updated by Viktor Gurov over 2 years ago

  • Category changed from Web Interface to Package System

See also #9755

Actions #2

Updated by Kris Phillips over 2 years ago

Viktor Gurov wrote in #note-1:

See also #9755

I understand Jim's comments on that redmine, but it seems since we're putting more and more proprietary packages into the package manager, we probably should think about this more seriously. We should just add a field that hides the link if there is a flag to do so in the package.

Actions #3

Updated by Jim Pingle over 2 years ago

The other issue isn't really related. They are two distinct problems that wouldn't have a common solution.

This one could be solved by adding a feature to the package system which allows a package to override a value for its changeloglink so it can point to some other URL that isn't on github, or optionally disable the link in some way.

Some packages would be better served by having the version number link to a forum thread or category, others may want to link to a page in the docs. Letting each package override it would let us define custom URLs for internal packages as needed, or disable them if we don't have any public-facing page with that sort of information.

Actions #4

Updated by Kris Phillips about 10 hours ago

Testing this on 24.03, this seems to be less of an issue since it looks like the FreeBSD-ports tree has empty/blank packages with no commits for the packages that are proprietary.

Actions

Also available in: Atom PDF