Regression #12817
closed
PHP error when terminating OpenVPN sessions via the dashboard widget
Added by Yuri Weinstein about 2 years ago.
Updated about 2 years ago.
Plus Target Version:
22.05
Affected Architecture:
All
Description
If a user clicks on x next to the session on the OpenVPN dashboard widget as here
PHP ERROR is thrown and this functionality is broken
PHP errors
PHP ERROR: Type: 1, File: /etc/inc/openvpn.inc, Line: 2106, Message: Uncaught ArgumentCountError: Too few arguments to function openvpn_kill_client(), 2 passed in /usr/local/www/widgets/widgets/openvpn.widget.php on line 285 and exactly 3 expected in /etc/inc/openvpn.inc:2106
Stack trace:
#0 /usr/local/www/widgets/widgets/openvpn.widget.php(285): openvpn_kill_client('server1', '192.168.70.13:4...')
#1 {main}
thrown @ 2022-02-17 07:15:22
Files
- Related to Feature #12416: Support OpenVPN ``client-kill`` to terminate remote clients instead of clearing their session added
- Tracker changed from Bug to Regression
- Assignee set to Viktor Gurov
- Target version set to CE-Next
- Plus Target Version set to 22.05
- Affected Version set to 2.6.0
- Status changed from New to Pull Request Review
- Target version changed from CE-Next to 2.7.0
- Status changed from Pull Request Review to Feedback
- % Done changed from 0 to 100
@Viktor
Thx a million!
But I could not apply it:
Patch Test Output apply:
/usr/bin/patch --directory=/ -t -p2 -i /var/patches/620ebb1139990.patch --check --forward --ignore-whitespace
Hmm... I can't seem to find a patch in there anywhere.
Retested again and applied the patch successfully and it fixed the issue, thank you!
- Has duplicate Bug #12825: PHP Fatal error when attempting to kill an established OVPN connection via the dashboard widget added
- Has duplicate Bug #12858: OpenVPN bug, close connection error added
- Status changed from Feedback to Resolved
Tested on
22.05-DEVELOPMENT (amd64)
built on Tue Mar 08 06:20:23 UTC 2022
FreeBSD 12.3-STABLE
Both kill and halt functioning as expected. Marked as resolved.
- Subject changed from Killing OpenVPN session via the dashboard widget is broken in 2.6.0 to PHP error when terminating OpenVPN sessions via the dashboard widget
Updating subject for release notes.
Also available in: Atom
PDF
Updated by Viktor Gurov 
Updated by 
Updated by 
Updated by