Bug #13088
closed
Rapidly clicking certain options on OpenVPN Client Overrides can cause hide/show field behavior to invert
Added by Phil Wardt over 2 years ago.
Updated over 1 year ago.
Plus Target Version:
23.09
Description
in client specific overrides, NTP and DNS options: use javascript instead of toggles class because the latter causes inverted results when repeating clicks too quickly. This also matches the code used in the server page
Completes OpenVPN GUI fixes:
https://redmine.pfsense.org/issues/13087
Files
I replicated the issue with inverted results when repeating clicks too quickly on 22.05.r.20220604.1403.
After applying the patch, it works fine.
- Status changed from New to Pull Request Review
I can confirm this behavior is present on the:
22.05-RELEASE (amd64)
built on Wed Jun 22 18:56:13 UTC 2022
FreeBSD 12.3-STABLE
The patch fixes the issue. It can be merged.
Can't replicate the issue on
23.05-DEVELOPMENT (amd64)
built on Mon Jan 09 06:04:59 UTC 2023
FreeBSD 14.0-CURRENT
Correcting,
Replicable on 23.05 and 23.01
- Target version set to 2.7.0
- Plus Target Version set to 23.05
- Plus Target Version changed from 23.05 to 23.09
- Status changed from Pull Request Review to Feedback
- % Done changed from 0 to 100
- Status changed from Feedback to Resolved
Working OK on the latest build as far as I can tell.
- Subject changed from OpenVPN Client Overrides: properly hide/show form fields to Rapidly clicking certain options on OpenVPN Client Overrides can cause hide/show field behavior to invert
Updating subject for release notes.
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by 
Updated by