Regression #13155
closed
Rule labels in pftop output are not correct
100%
Description
The output from pftop uses the first label from the rule, so it's getting other incorrect labels now such as the rule ID. Similar to #12977
I've got some changes that fix it by reordering the labels in filter.inc which seems to make it happier without taking on making changes upstream in pftop.
Files
Related issues
Updated by Jim Pingle almost 2 years ago
- Related to Regression #12977: Rule descriptions in firewall logs show wrong rule label added
Updated by Jim Pingle almost 2 years ago
MR: https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/780
After applying the patch to test, check the contents of rules.debug, pftop in label view, and the firewall logs to ensure the correct description is shown in each location.
Updated by Marcos M almost 2 years ago
Looks good. Tested on 22.05.b.20220517.0600.
Before patch pftop -v label did not show rule labels with USER_RULE:. After patch, they show correctly, filter logs show correctly (no change), and /tmp/rules.debug shows the labels reversed.
No change on https://redmine.pfsense.org/issues/13156
Updated by Jim Pingle almost 2 years ago
- Status changed from Pull Request Review to Feedback
- % Done changed from 0 to 100
Applied in changeset a913a049bf3c8004a68cc8711251c7a177e0760a.
Updated by Jim Pingle almost 2 years ago
- Status changed from Feedback to Resolved
All good now. Proper labels are shown in pftop label view and it didn't negatively impact the firewall log view.