Project

General

Profile

Actions

Regression #13155

closed

Rule labels in pftop output are not correct

Added by Jim Pingle about 2 months ago. Updated 28 days ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Rules / NAT
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
22.05
Release Notes:
Force Exclusion
Affected Version:
Affected Architecture:

Description

The output from pftop uses the first label from the rule, so it's getting other incorrect labels now such as the rule ID. Similar to #12977

I've got some changes that fix it by reordering the labels in filter.inc which seems to make it happier without taking on making changes upstream in pftop.


Files

780.diff (5.13 KB) 780.diff Jim Pingle, 05/12/2022 11:10 AM

Related issues

Related to Regression #12977: Rule descriptions in firewall logs show wrong rule labelResolvedReid Linnemann

Actions
Actions #1

Updated by Jim Pingle about 2 months ago

  • Related to Regression #12977: Rule descriptions in firewall logs show wrong rule label added
Actions #2

Updated by Jim Pingle about 2 months ago

MR: https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/780

After applying the patch to test, check the contents of rules.debug, pftop in label view, and the firewall logs to ensure the correct description is shown in each location.

Actions #3

Updated by Jim Pingle about 1 month ago

Rebased patch.

Actions #4

Updated by Marcos Mendoza about 1 month ago

Looks good. Tested on 22.05.b.20220517.0600.

Before patch pftop -v label did not show rule labels with USER_RULE:. After patch, they show correctly, filter logs show correctly (no change), and /tmp/rules.debug shows the labels reversed.

No change on https://redmine.pfsense.org/issues/13156

Actions #5

Updated by Jim Pingle about 1 month ago

  • Status changed from Pull Request Review to Feedback
  • % Done changed from 0 to 100
Actions #6

Updated by Jim Pingle 28 days ago

  • Status changed from Feedback to Resolved

All good now. Proper labels are shown in pftop label view and it didn't negatively impact the firewall log view.

Actions

Also available in: Atom PDF