Regression #13155
closed
Rule labels in pftop output are not correct
Added by Jim Pingle almost 4 years ago.
Updated almost 4 years ago.
Plus Target Version:
22.05
Release Notes:
Force Exclusion
Description
The output from pftop uses the first label from the rule, so it's getting other incorrect labels now such as the rule ID. Similar to #12977
I've got some changes that fix it by reordering the labels in filter.inc which seems to make it happier without taking on making changes upstream in pftop.
Files
- Related to Regression #12977: Rule descriptions in firewall logs show wrong rule label added
Looks good. Tested on 22.05.b.20220517.0600.
Before patch pftop -v label did not show rule labels with USER_RULE:. After patch, they show correctly, filter logs show correctly (no change), and /tmp/rules.debug shows the labels reversed.
No change on https://redmine.pfsense.org/issues/13156
- Status changed from Pull Request Review to Feedback
- % Done changed from 0 to 100
Applied in changeset commit:a913a049bf3c8004a68cc8711251c7a177e0760a.
- Status changed from Feedback to Resolved
All good now. Proper labels are shown in pftop label view and it didn't negatively impact the firewall log view.
Also available in: Atom
PDF