Project

General

Profile

Actions
Copy link

Bug #13169

closed

captiveportal_ether_delete_entry() does not delete anchors/pipes

Added by Viktor Gurov over 2 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Reid Linnemann
Category:
Captive Portal
Target version:
2.7.0
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
22.05
Release Notes:
Force Exclusion
Affected Version:
2.7.0
Affected Architecture:

Description

For some reason, pfSense_pf_cp_get_eth_pipes(), and pfSense_pf_cp_flush() does not work properly inside captiveportal_ether_delete_entry().
But if I use pfSense_pf_cp_flush() on any WebGUI page, it works as expected.

Plus, pfSense_pf_cp_get_eth_pipes() returns four values (for example 2001, 2002, 2003, 2004) instead of two (pipeup, pipedown).

Related issues

Related to Todo #13100: Transition Captive Portal from IPFW to PFResolvedViktor Gurov

Actions
Related to Regression #13191: Deleting a passthru mac entry fails to remove pf rules and dummynet pipes associated with the passthru macResolvedReid Linnemann

Actions
Actions
Copy link
 #1

Updated by Viktor Gurov over 2 years ago

https://github.com/pfsense/pfsense/blob/master/src/etc/inc/captiveportal.inc#L1098

same issue after replacing $host with {$host} in pfSense_pf_cp_get_eth_pipes()

Actions
Copy link
 #2

Updated by Reid Linnemann over 2 years ago

Getting back 4 entries would indicate to me that the anchor path matches more than one rule, and you are getting the up/down pipes for two matched rules

Actions
Copy link
 #3

Updated by Reid Linnemann over 2 years ago

I see what I did, I was expecting a single rule and that I should return its dnpipe and dnrpipe, when in actuality there are two rules each with a dnpipe. I'll fix that up.

Actions
Copy link
 #4

Updated by Reid Linnemann over 2 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

Fixed in 1c887f5e

Actions
Copy link
 #5

Updated by Viktor Gurov over 2 years ago

  • Status changed from Feedback to New
  • % Done changed from 100 to 50

pfSense_pf_cp_get_eth_pipes() issue is fixed:
https://github.com/pfsense/FreeBSD-ports/commit/1c887f5eb2429fbc80409bd51f84157e13b7b887

But pfSense_pf_cp_get_eth_pipes(), and pfSense_pf_cp_flush() still does not work properly inside captiveportal_ether_delete_entry().

Actions
Copy link
 #6

Updated by Viktor Gurov over 2 years ago

  • Assignee changed from Reid Linnemann to Viktor Gurov
Actions
Copy link
 #7

Updated by Jim Pingle over 2 years ago

  • Status changed from New to Pull Request Review
Actions
Copy link
 #8

Updated by Viktor Gurov over 2 years ago

  • Status changed from Pull Request Review to Feedback
Actions
Copy link
 #9

Updated by Viktor Gurov over 2 years ago

  • Related to Todo #13100: Transition Captive Portal from IPFW to PF added
Actions
Copy link
 #10

Updated by Reid Linnemann over 2 years ago

We still seem to have issues around passthru mac deletion. I see that pipes persist after we remove a mac entry.

Actions
Copy link
 #11

Updated by Reid Linnemann over 2 years ago

  • Status changed from Feedback to Assigned
  • Assignee changed from Viktor Gurov to Reid Linnemann
Actions
Copy link
 #12

Updated by Reid Linnemann over 2 years ago

  • Status changed from Assigned to Feedback
  • % Done changed from 50 to 100

passthru mac is a separate issue

Actions
Copy link
 #13

Updated by Reid Linnemann over 2 years ago

  • Related to Regression #13191: Deleting a passthru mac entry fails to remove pf rules and dummynet pipes associated with the passthru mac added
Actions
Copy link
 #14

Updated by Reid Linnemann over 2 years ago

  • Status changed from Feedback to Resolved
Actions
Copy link

Also available in: Atom PDF