Bug #13169
closed
captiveportal_ether_delete_entry() does not delete anchors/pipes
Added by Viktor Gurov over 2 years ago.
Updated over 2 years ago.
Plus Target Version:
22.05
Release Notes:
Force Exclusion
Description
For some reason, pfSense_pf_cp_get_eth_pipes(), and pfSense_pf_cp_flush() does not work properly inside captiveportal_ether_delete_entry().
But if I use pfSense_pf_cp_flush() on any WebGUI page, it works as expected.
Plus, pfSense_pf_cp_get_eth_pipes() returns four values (for example 2001, 2002, 2003, 2004) instead of two (pipeup, pipedown).
Getting back 4 entries would indicate to me that the anchor path matches more than one rule, and you are getting the up/down pipes for two matched rules
I see what I did, I was expecting a single rule and that I should return its dnpipe and dnrpipe, when in actuality there are two rules each with a dnpipe. I'll fix that up.
- Status changed from New to Feedback
- % Done changed from 0 to 100
- Status changed from Feedback to New
- % Done changed from 100 to 50
- Assignee changed from Reid Linnemann to Viktor Gurov
- Status changed from New to Pull Request Review
- Status changed from Pull Request Review to Feedback
- Related to Todo #13100: Transition Captive Portal from IPFW to PF added
We still seem to have issues around passthru mac deletion. I see that pipes persist after we remove a mac entry.
- Status changed from Feedback to Assigned
- Assignee changed from Viktor Gurov to Reid Linnemann
- Status changed from Assigned to Feedback
- % Done changed from 50 to 100
passthru mac is a separate issue
- Related to Regression #13191: Deleting a passthru mac entry fails to remove pf rules and dummynet pipes associated with the passthru mac added
- Status changed from Feedback to Resolved
Also available in: Atom
PDF
Updated by Viktor Gurov 
Updated by 
Updated by