Todo #13268
closedDynamically adjust the interface name maximum width in the login banner
100%
Description
small change to add some width and better align things if interface names are longer than just "WAN", "WAN2" etc.
before:
after:
Files
Updated by → luckman212 over 2 years ago
I wanted to auto size the columns based on the terminal width, but the shell doesn't seem to export the $COLUMNS
variable that would be required to do that.
anyway- PR: https://github.com/pfsense/pfsense/pull/4598
Updated by Marcos M about 1 year ago
- Status changed from Ready To Test to Pull Request Review
- Assignee set to Marcos M
The max interface description is known (31 iirc), and the real interface name is almost always relatively short, hence I think we can rely on the line-wrapping feature and not introduce a fixed width. We can calculate the max width and go with that, e.g.: Show
https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/1097
Updated by Marcos M about 1 year ago
- Subject changed from columns don't align nicely in console with medium-long interface names to Dynamically adjust tHe interface text max wdith for the login banner
Updated by Marcos M almost 1 year ago
- Status changed from Pull Request Review to Feedback
Applied in changeset f15e8e4fb1db624c04eeda8671c6b7fb34a87b03.
Updated by Danilo Zrenjanin 12 months ago
- Status changed from Feedback to Resolved
Tested the patch on the 23.09.1
It looks good.
I am marking this case resolved.
Updated by Jim Pingle 10 months ago
- Subject changed from Dynamically adjust the interface text max width in the login banner to Dynamically adjust the interface name maximum width in the login banner