Project

General

Profile

Actions

Todo #13268

closed

Dynamically adjust the interface name maximum width in the login banner

Added by → luckman212 almost 2 years ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Console Menu
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
24.03
Release Notes:
Default

Description

small change to add some width and better align things if interface names are longer than just "WAN", "WAN2" etc.

before:

after:


Files

Actions #1

Updated by → luckman212 almost 2 years ago

I wanted to auto size the columns based on the terminal width, but the shell doesn't seem to export the $COLUMNS variable that would be required to do that.

anyway- PR: https://github.com/pfsense/pfsense/pull/4598

Actions #2

Updated by Marcos M 4 months ago

  • Status changed from Ready To Test to Pull Request Review
  • Assignee set to Marcos M

The max interface description is known (31 iirc), and the real interface name is almost always relatively short, hence I think we can rely on the line-wrapping feature and not introduce a fixed width. We can calculate the max width and go with that, e.g.: Show

https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/1097

Actions #3

Updated by Marcos M 4 months ago

  • Subject changed from columns don't align nicely in console with medium-long interface names to Dynamically adjust tHe interface text max wdith for the login banner
Actions #4

Updated by Marcos M 4 months ago

  • Status changed from Pull Request Review to Feedback
Actions #5

Updated by Marcos M 3 months ago

  • Subject changed from Dynamically adjust tHe interface text max wdith for the login banner to Dynamically adjust the interface text max wdith in the login banner
  • Target version set to 2.8.0
  • Plus Target Version set to 24.03
Actions #6

Updated by Marcos M 3 months ago

  • Subject changed from Dynamically adjust the interface text max wdith in the login banner to Dynamically adjust the interface text max width in the login banner
Actions #7

Updated by Danilo Zrenjanin 3 months ago

  • Status changed from Feedback to Resolved

Tested the patch on the 23.09.1

It looks good.

I am marking this case resolved.

Actions #8

Updated by Jim Pingle about 1 month ago

  • Subject changed from Dynamically adjust the interface text max width in the login banner to Dynamically adjust the interface name maximum width in the login banner
Actions

Also available in: Atom PDF