Project

General

Profile

Actions

Todo #13268

closed
→L MM

Dynamically adjust the interface name maximum width in the login banner

Todo #13268: Dynamically adjust the interface name maximum width in the login banner

Added by → luckman212 about 4 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Console Menu
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
24.03
Release Notes:
Default

Description

small change to add some width and better align things if interface names are longer than just "WAN", "WAN2" etc.

before:

after:


Files

→L Updated by → luckman212 about 4 years ago Actions #1

I wanted to auto size the columns based on the terminal width, but the shell doesn't seem to export the $COLUMNS variable that would be required to do that.

anyway- PR: https://github.com/pfsense/pfsense/pull/4598

MM Updated by Marcos M almost 3 years ago Actions #2

  • Status changed from Ready To Test to Pull Request Review
  • Assignee set to Marcos M

The max interface description is known (31 iirc), and the real interface name is almost always relatively short, hence I think we can rely on the line-wrapping feature and not introduce a fixed width. We can calculate the max width and go with that, e.g.: Show

https://gitlab.netgate.com/pfSense/pfSense/-/merge_requests/1097

MM Updated by Marcos M almost 3 years ago Actions #3

  • Subject changed from columns don't align nicely in console with medium-long interface names to Dynamically adjust tHe interface text max wdith for the login banner

MM Updated by Marcos M over 2 years ago Actions #4

  • Status changed from Pull Request Review to Feedback

Applied in changeset commit:f15e8e4fb1db624c04eeda8671c6b7fb34a87b03.

MM Updated by Marcos M over 2 years ago Actions #5

  • Subject changed from Dynamically adjust tHe interface text max wdith for the login banner to Dynamically adjust the interface text max wdith in the login banner
  • Target version set to 2.8.0
  • Plus Target Version set to 24.03

MM Updated by Marcos M over 2 years ago Actions #6

  • Subject changed from Dynamically adjust the interface text max wdith in the login banner to Dynamically adjust the interface text max width in the login banner

DZ Updated by Danilo Zrenjanin over 2 years ago Actions #7

  • Status changed from Feedback to Resolved

Tested the patch on the 23.09.1

It looks good.

I am marking this case resolved.

JP Updated by Jim Pingle over 2 years ago Actions #8

  • Subject changed from Dynamically adjust the interface text max width in the login banner to Dynamically adjust the interface name maximum width in the login banner
Actions

Also available in: Atom